Support @abstract functions #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranquilMarmot
commented
Jul 6, 2025
| ] | ||
|
|
||
|
|
||
| def is_abstract_annotation_for_statement(statement: Tree, next_statement: Tree) -> bool: |
There was a problem hiding this comment.
Had to do some extra checks in order to get the @abstract annotation on the same line as func/class_name/class.
Based on the reference to @abstract here:
https://godotengine.org/article/dev-snapshot-godot-4-5-beta-2/
and looking at the GDScript style guide, it does seem like the @ annotations are supposed to be on the same line as what they're modifying.
TranquilMarmot
commented
Jul 6, 2025
| blank_lines = _add_extra_blanks_due_to_next_statement( | ||
| blank_lines, statement.data, surrounding_empty_lines_table | ||
| ) | ||
| is_first_annotation = len(context.annotations) == 1 |
There was a problem hiding this comment.
Had to refactor this function a bit to get around:
lint: commands[0]> pylint -rn -j0 setup.py gdtoolkit/ tests/ --rcfile=pylintrc
************* Module gdtoolkit.formatter.block
gdtoolkit/formatter/block.py:21:0: R0914: Too many local variables (16/15) (too-many-locals)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387