Enables HTTPS in Anthias #1940
Draft
Enables HTTPS in Anthias #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't think this is a good idea. Shipping self signed certs goes against most modern best practices. Instead we should probably make an integration with acme.sh and/or Tailscale for getting a real certificate. |
|
Contributor
Author
|
@vpetersson, I can update this branch and then add a feature that lets users upload their own certificates. |
Contributor
|
I kinda want something more intelligent. Ideally something that can easily be integrated with Let's Encrypt and/or Tailscale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful References
Description