Skip to content

Conversation

@nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Dec 16, 2025

Description

  • Switched from Poetry to uv for managing host dependencies
  • Switching from pip to uv for managing dependencies in containers will be done in a separate PR.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project from Poetry to uv for managing host dependencies. The change updates the dependency management tool while maintaining the same functionality.

Key Changes:

  • Replaced Poetry with uv for dependency management
  • Updated pyproject.toml to use dependency groups instead of Poetry's group structure
  • Added uv.lock file and removed poetry.lock
  • Updated all CI/CD workflows and development scripts to use uv commands

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
pyproject.toml Converted from Poetry format to PEP 621 standard with uv dependency groups
uv.lock New lock file generated by uv (replaces poetry.lock)
poetry.lock Deleted as part of migration from Poetry
docs/developer-documentation.md Updated documentation to reference uv instead of Poetry
docker/Dockerfile.dev Changed to install and use uv instead of Poetry
bin/generate_dev_mode_dockerfiles.sh Updated script to use uv run command
.python-version Added Python version file for uv
.github/workflows/*.yml Updated all workflows to use uv actions and commands

Critical Issues Found:

  • The uv.lock file contains package versions with future dates (2025-09-08, 2025-10-14, 2025-11-12) that don't exist yet
  • Incorrect uv pip install --group commands throughout - should be uv sync --group
  • Unrelated workflow changes (trigger change, removed --push flag) not mentioned in PR description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

@nicomiguelino nicomiguelino marked this pull request as ready for review December 16, 2025 05:05
@nicomiguelino nicomiguelino requested a review from a team as a code owner December 16, 2025 05:05
@nicomiguelino nicomiguelino merged commit 29ae072 into Screenly:master Dec 16, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Anthias Dec 16, 2025
@nicomiguelino nicomiguelino deleted the migrate-poetry-to-uv branch December 16, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant