feat: Add Operation Type support#215
Closed
rmanganiello wants to merge 6 commits intoSectorLabs:masterfrom
Closed
Conversation
There are pre-existing typing issues in the project that seems to be ignored because the functions don't have typing hints.
Contributor
|
Nice trick! I am not a fan of the API for this. We already have dynamic return types in Could we maybe abstract this in a separate method? |
Contributor
|
I am closing this because nobody has stepped up to get this PR into a mergable shape. Maybe one day somebody has the motivation to get this in a mergable shape. Until then, hopefully somebody comes across this and finds it useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, there's no way to determine if after an UPSERT operation in the database
a row was inserted or updated.
This functionality can be handy in different use cases.
i.e.:
Solution
This PR intends to add this functionality by adding a new flag called
return_operation_type.When the client specifies this flag, a new key
_operation_typewill be returned for each rowsetting the corresponding operation ("INSERT" or "UPDATE") that was performed for it.
This new flag will be available in the
bulk_upsertandbulk_insertmethods of thePostgresQuerySetclass, and, only if the
return_modelflag is off.Caveats
return_modelflag is off to avoid breaking the current contractssince injecting this data into a Django Model is hacky.
clients are building their own Django models by hand after calling the bulk_upsert/bulk_insert methods.
Related Issue: #100