Skip to content

Conversation

@sweatbuckets
Copy link
Contributor

@sweatbuckets sweatbuckets commented Jan 1, 2026

  1. #⃣ 연관된 이슈
    • 관련 이슈를 명시해주세요.
    • 예: #이슈번호#이슈번호
  2. 📝 작업 내용
    • url은 프론트 호환 고려해서 미수정
  3. 📸 스크린샷 (선택)
    • 작업 내용을 시각적으로 표현할 스크린샷을 포함하세요.
  4. 💬 리뷰 요구사항 (선택)
    • 리뷰어가 특히 검토해주었으면 하는 부분이 있다면 작성해주세요.
    • 예: "메서드 XXX의 이름을 더 명확히 하고 싶은데, 좋은 아이디어가 있으신가요?"

Summary by CodeRabbit

  • New Features
    • Added a new endpoint to retrieve recently trending amateur shows, enabling users to discover currently popular small theater productions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

The controller was refactored to correct the service method call in getShowRanking and a new public HTTP endpoint was added to expose the getRecentlyHotShow functionality with updated API documentation.

Changes

Cohort / File(s) Summary
Controller Endpoint Updates
src/main/java/cc/backend/amateurShow/controller/AmateurController.java
Modified getShowRanking to call getShowRanking(memberId) instead of getRecentlyHotShow(memberId). Added new public endpoint getRecentlyHotShow for path /incoming that calls amateurService.getRecentlyHotShow(member.getId()) with Operation summary "요즘 핫한 소극장 연극 조회 API".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A controller springs forth, so neat and spry,
Hot shows now exposed 'neath the /incoming sky!
Method calls corrected, endpoints aligned,
Amateur theater treasures, perfectly defined! 🎭

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The description is largely a template placeholder with minimal actual content; only one work item is described while the PR actually contains multiple changes (method renaming and possible pagination adjustments). Replace template placeholders with concrete details: specify the related issue number, provide a detailed explanation of method name changes and pagination adjustments, and clarify which specific review feedback is requested.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main changes: method name modification and page size adjustment, matching the primary changes in the code.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f763b1 and 08b2909.

📒 Files selected for processing (1)
  • src/main/java/cc/backend/amateurShow/controller/AmateurController.java
🔇 Additional comments (1)
src/main/java/cc/backend/amateurShow/controller/AmateurController.java (1)

68-68: LGTM! Bug fix correctly aligns service call with method name.

The service call now correctly invokes getShowRanking instead of the previously mismatched getRecentlyHotShow. This ensures the /ranking endpoint properly fetches ranking data.

Comment on lines +92 to +96
@GetMapping("/incoming")
@Operation(summary = "요즘 핫한 소극장 연극 조회 API")
public ApiResponse<List<AmateurShowResponseDTO.AmateurShowList>> getRecentlyHotShow(@AuthenticationPrincipal(expression = "member") Member member) {
return ApiResponse.onSuccess(amateurService.getRecentlyHotShow(member.getId()));//
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, find the AmateurController.java file
find . -name "AmateurController.java" -type f

Repository: SeeATheater/CC_Backend

Length of output: 138


🏁 Script executed:

# Read lines 92-96 from the controller file
sed -n '92,96p' ./src/main/java/cc/backend/amateurShow/controller/AmateurController.java

Repository: SeeATheater/CC_Backend

Length of output: 396


🏁 Script executed:

# Find the AmateurService file
find . -name "*AmateurService*" -type f

Repository: SeeATheater/CC_Backend

Length of output: 241


🏁 Script executed:

# Search for getRecentlyHotShow method in both files
echo "=== Searching in AmateurService.java ==="
rg -n "getRecentlyHotShow" ./src/main/java/cc/backend/amateurShow/service/amateurShowService/AmateurService.java

echo "=== Searching in AmateurServiceImpl.java ==="
rg -n "getRecentlyHotShow" ./src/main/java/cc/backend/amateurShow/service/amateurShowService/AmateurServiceImpl.java

Repository: SeeATheater/CC_Backend

Length of output: 334


Remove unnecessary trailing comment.

Line 95 contains an unnecessary trailing // comment that should be removed for code cleanliness.

Fix
-        return ApiResponse.onSuccess(amateurService.getRecentlyHotShow(member.getId()));//
+        return ApiResponse.onSuccess(amateurService.getRecentlyHotShow(member.getId()));

The URL path /incoming doesn't semantically align with "요즘 핫한 소극장 연극" (recently hot shows), though this design choice is acceptable for frontend compatibility.

🤖 Prompt for AI Agents
In src/main/java/cc/backend/amateurShow/controller/AmateurController.java around
lines 92 to 96, there is an unnecessary trailing comment marker "//" at the end
of the return statement on line 95; remove the trailing "//" so the return
statement ends cleanly and reformat the line if needed to match project style.

@sweatbuckets sweatbuckets merged commit 65a8526 into develop Jan 1, 2026
2 checks passed
This was referenced Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants