-
Notifications
You must be signed in to change notification settings - Fork 1
[FIX] 메서드 이름 수정및 페이지 크기 조절 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe controller was refactored to correct the service method call in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/cc/backend/amateurShow/controller/AmateurController.java
🔇 Additional comments (1)
src/main/java/cc/backend/amateurShow/controller/AmateurController.java (1)
68-68: LGTM! Bug fix correctly aligns service call with method name.The service call now correctly invokes
getShowRankinginstead of the previously mismatchedgetRecentlyHotShow. This ensures the/rankingendpoint properly fetches ranking data.
| @GetMapping("/incoming") | ||
| @Operation(summary = "요즘 핫한 소극장 연극 조회 API") | ||
| public ApiResponse<List<AmateurShowResponseDTO.AmateurShowList>> getRecentlyHotShow(@AuthenticationPrincipal(expression = "member") Member member) { | ||
| return ApiResponse.onSuccess(amateurService.getRecentlyHotShow(member.getId()));// | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# First, find the AmateurController.java file
find . -name "AmateurController.java" -type fRepository: SeeATheater/CC_Backend
Length of output: 138
🏁 Script executed:
# Read lines 92-96 from the controller file
sed -n '92,96p' ./src/main/java/cc/backend/amateurShow/controller/AmateurController.javaRepository: SeeATheater/CC_Backend
Length of output: 396
🏁 Script executed:
# Find the AmateurService file
find . -name "*AmateurService*" -type fRepository: SeeATheater/CC_Backend
Length of output: 241
🏁 Script executed:
# Search for getRecentlyHotShow method in both files
echo "=== Searching in AmateurService.java ==="
rg -n "getRecentlyHotShow" ./src/main/java/cc/backend/amateurShow/service/amateurShowService/AmateurService.java
echo "=== Searching in AmateurServiceImpl.java ==="
rg -n "getRecentlyHotShow" ./src/main/java/cc/backend/amateurShow/service/amateurShowService/AmateurServiceImpl.javaRepository: SeeATheater/CC_Backend
Length of output: 334
Remove unnecessary trailing comment.
Line 95 contains an unnecessary trailing // comment that should be removed for code cleanliness.
Fix
- return ApiResponse.onSuccess(amateurService.getRecentlyHotShow(member.getId()));//
+ return ApiResponse.onSuccess(amateurService.getRecentlyHotShow(member.getId()));The URL path /incoming doesn't semantically align with "요즘 핫한 소극장 연극" (recently hot shows), though this design choice is acceptable for frontend compatibility.
🤖 Prompt for AI Agents
In src/main/java/cc/backend/amateurShow/controller/AmateurController.java around
lines 92 to 96, there is an unnecessary trailing comment marker "//" at the end
of the return statement on line 95; remove the trailing "//" so the return
statement ends cleanly and reformat the line if needed to match project style.
#이슈번호,#이슈번호Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.