[scautoloc] Add DepthLookup plugin support via factory interface#127
Draft
comoglu wants to merge 1 commit into
Draft
[scautoloc] Add DepthLookup plugin support via factory interface#127comoglu wants to merge 1 commit into
comoglu wants to merge 1 commit into
Conversation
Wire scautoloc to the Seismology::DepthLookupFactory from seiscomp/common (PR #199). The local backend implementation is removed; depth lookup is now delegated to whichever plugin is loaded via the plugins config key. - autoloc.depthLookup = Constant (default, no behaviour change) - autoloc.depthLookup = Slab2 (requires slab2depthlookup plugin) - _defaultDepthAt() / _maxDepthAt() helpers replace _config.defaultDepth and _config.maxDepth at all geographic-lookup call sites - scconfig is passed to plugin init() so plugins can read their own keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seismology::DepthLookupFactoryfrom seiscomp/common (PR #199)_defaultDepthAt()/_maxDepthAt()helpers that replace_config.defaultDepthand_config.maxDepthat all geographic-lookup call sitesautoloc.depthLookup = Constant(the built-in backend from common)How to use
Load a DepthLookup plugin and set the backend in
scautoloc.cfg:The Slab2 backend is provided by https://github.com/comoglu/seiscomp-slab2-plugin — a standalone installable plugin using USGS Slab2.0 depth-contour BNA files. Proof-of-concept tested with a live playback: plugin loads 531 BNA files across 30 zones and correctly identifies slab depths (e.g. Kuril zone at 40 km).
Relationship to previous PRs
Supersedes PR #126 (
feature/depthlookup-v2), which compiled Slab2 directly into scautoloc. This branch takes the cleaner approach agreed with Joachim and Jan: scautoloc is a plugin consumer only, backends live outside.Test plan
autoloc.depthLookup = Constant(default) — no behaviour change, existing tests passautoloc.depthLookup = Slab2with slab2depthlookup plugin loaded — slab depth applied, verified in log