feat: drop support for PHP <= 7.3 #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Composer supports PHP 7.2 and uses that library (this is even why the library was created initially). So bumping the min PHP version to 7.4 looks wrong to me. |
|
Ok, in this case, maybe it is time to drop support for PHP <= 7.1 ? |
|
Yeah maybe dropping <=7.1 makes sense, but this repo is also so stable that it doesn't cost much to keep supporting older versions IMO.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it is time to drop support for PHP <= 7.3 ?
Version Stats:
https://packagist.org/packages/seld/jsonlint/php-stats#1
I only changed the tests.