Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TestCase to MonologTestCase #1953

Merged
merged 5 commits into from
Mar 16, 2025
Merged

Rename TestCase to MonologTestCase #1953

merged 5 commits into from
Mar 16, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 16, 2025

closes #1951

@staabm
Copy link
Contributor Author

staabm commented Mar 16, 2025

instead of a class_alias I went with a regular class and marked it as @deprecated.
that way consumers of this lib - or other projects which mistakenly used the old base-class - will see phpstorm/phpstan reports about the wrongly used class-name (when using class-alias the old class-name cannot be marked as deprecated)


the failling build looks unrelated.. it errored - at least on my machine - even before this PR

-> build fixes in #1954

@staabm staabm marked this pull request as ready for review March 16, 2025 09:42
@Seldaek Seldaek merged commit 7ca003e into Seldaek:main Mar 16, 2025
10 checks passed
@Seldaek
Copy link
Owner

Seldaek commented Mar 16, 2025

Thanks

@Seldaek Seldaek added this to the 3.x milestone Mar 16, 2025
@staabm staabm deleted the dep-test branch March 16, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename TestCase class to prevent import conflicts with PHPUnit's TestCase
2 participants