Skip to content

Conversation

@tyndria
Copy link
Contributor

@tyndria tyndria commented Oct 13, 2025

What

Summary of changes

  • Replaced default channel image with the community-managed image.
  • Remove explicit git installation as it's already a part of the used image

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

  • Executed python_lint GH workflow locally with the new private image using act - working ✅
  • Executed python_tests GH workflow by building the image inside the GH runner - output here - passed ✅
  • Pushed python package to the pypi test index from the python-builder container - ✅

Next steps

  • Push the new image to the seldonio hub
  • Update the image tag in the workflows and makefiles (incl. run_python_builder command)

After we upgrade python in tests, we could upgrade python and conda version in this Dockerfile (cc @vtaskow)


# Installs required
RUN apt-get install -y curl
RUN apt-get update && apt-get install -y curl && rm -rf /var/lib/apt/lists/*
Copy link
Contributor Author

@tyndria tyndria Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's better to move to the pipx installation of poetry after we upgrade python and the base condaforge/miniforge3 image, so we would get rid of this line
cc @vtaskow

# This is to install desired version of Python without updating conda version
ENV PYTHON_VERSION "3.7.10"
ENV CONDA_VERSION "4.7.12"
ENV PYTHON_VERSION="3.7.10"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to upgrade conda and python here after tests are upgraded
cc @vtaskow

@@ -1,12 +1,11 @@
FROM continuumio/miniconda3:4.12.0
FROM condaforge/miniforge3:4.12.0-2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to upgrade this image after python tests are upgraded
cc @vtaskow


on:
push:
branches: [ master ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for testing purposes only (to test workflow after we push the image)

@tyndria tyndria marked this pull request as ready for review October 14, 2025 10:11
@lc525 lc525 added the v1 label Oct 20, 2025
@tyndria tyndria changed the title fix(conda): [part 1] Replace continuumio/miniconda3 with condaforge/miniforge3 WITHOUT upgrades fix(python-builder): [part 1] Replace continuumio/miniconda3 with condaforge/miniforge3 WITHOUT upgrades in python-builder image Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants