-
Notifications
You must be signed in to change notification settings - Fork 854
fix(python-builder): [part 1] Replace continuumio/miniconda3 with condaforge/miniforge3 WITHOUT upgrades in python-builder image
#6882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| # Installs required | ||
| RUN apt-get install -y curl | ||
| RUN apt-get update && apt-get install -y curl && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's better to move to the pipx installation of poetry after we upgrade python and the base condaforge/miniforge3 image, so we would get rid of this line
cc @vtaskow
| # This is to install desired version of Python without updating conda version | ||
| ENV PYTHON_VERSION "3.7.10" | ||
| ENV CONDA_VERSION "4.7.12" | ||
| ENV PYTHON_VERSION="3.7.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to upgrade conda and python here after tests are upgraded
cc @vtaskow
| @@ -1,12 +1,11 @@ | |||
| FROM continuumio/miniconda3:4.12.0 | |||
| FROM condaforge/miniforge3:4.12.0-2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to upgrade this image after python tests are upgraded
cc @vtaskow
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for testing purposes only (to test workflow after we push the image)
…e testing purpose" This reverts commit 564446f.
continuumio/miniconda3 with condaforge/miniforge3 WITHOUT upgradescontinuumio/miniconda3 with condaforge/miniforge3 WITHOUT upgrades in python-builder image
What
Summary of changes
gitinstallation as it's already a part of the used imageChecklist
Testing
python_lintGH workflow locally with the new private image usingact- working ✅python_testsGH workflow by building the image inside the GH runner - output here - passed ✅python-buildercontainer - ✅Next steps
seldoniohubrun_python_buildercommand)After we upgrade python in tests, we could upgrade python and conda version in this Dockerfile (cc @vtaskow)