fix(conda): [part 2] seldonio/core-builder image rework
#6884
Conversation
…te (tested on release script and helms generation for operator)
…/core-builder` image
| ENV PYTHON_VERSION "3.8.10" | ||
| ENV PYTHON_VERSION="3.8.10" | ||
|
|
||
| RUN printf '%s\n' \ |
There was a problem hiding this comment.
Ensure I could use this old openjdk:13.0.1-jdk-buster to allow gradual upgrade of this image.
Ideally we should change the base image, but I have to understand what to test apart from the ./release and operator helm scripts
| && rm -f /tmp/apache-maven.tar.gz \ | ||
| && ln -s /usr/share/maven/bin/mvn /usr/bin/mvn | ||
| RUN set -eux; \ | ||
| BASE_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries"; \ |
There was a problem hiding this comment.
Moved to archives as image building was failing. Temporary - until we replace the base image
…est on release, helm generation scripts and Java s2i examples
… on non‑x86_64 hosts (to always build images for linux/amd64)
|
|
||
| def update_dockerfile_label_version(seldon_core_version, debug=False): | ||
| paths = [ | ||
| "operator/Dockerfile.redhat", |
There was a problem hiding this comment.
These files don't exist
|
|
||
| MAVEN_REPOSITORY_LOCATION=/tmp/.m2/repository | ||
|
|
||
| PLATFORM_ARGS=() |
There was a problem hiding this comment.
To ensure image could be easily built on non x86_64 hosts
| MKFILE_DIR := $(dir $(MKFILE_PATH)) | ||
| SELDON_CORE_DIR := $(realpath $(MKFILE_DIR)/../..) | ||
|
|
||
| UNAME_M := $(shell uname -m) |
There was a problem hiding this comment.
To ensure image could be easily built on non x86_64 hosts
|
|
||
| RUN apt-get upgrade && \ | ||
| apt-get update | ||
| RUN printf '%s\n' \ |
There was a problem hiding this comment.
The base image is archived, so it's a temporary hack to build the image
| DOCKER_IMAGE_VERSION=0.30 | ||
| DOCKER_IMAGE_VERSION=0.31 | ||
|
|
||
| UNAME_M := $(shell uname -m) |
There was a problem hiding this comment.
To ensure image could be easily built on non x86_64 hosts
|
Image size is decreased after some dependencies were removed: 
|
2 participants
What
Summary of changes
seldonio/core-builderimage changesseldonio/core-builderimage at first and then get rid of conda downloads from the official anaconda channelcore-builderimage:jenkins,argo,gcloudseldonio/core-builderbase image (and installed dependencies)Related changes
seldonio/core-builderimage, I've decided to remove them to avoid confusionrelease.pyscript as some Dockerfiles don't exist anymoreChecklist
Testing
./release <version>script on top of the new imagemake -C operator/helm createon top of the new image