Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoints.zh-cn.md #2256

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Update endpoints.zh-cn.md #2256

wants to merge 4 commits into from

Conversation

HandyCC
Copy link

@HandyCC HandyCC commented Apr 4, 2025

User description

Description

Only some simple adjustments have been made to the Chinese translation to make it easier to read.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Improved readability and clarity of Chinese translation.

  • Updated terminology for consistency (e.g., "Standalone 模式" and "Hub-Node 模式").

  • Enhanced explanations for commands and their effects.

  • Fixed formatting issues and improved sentence structure.


Changes walkthrough 📝

Relevant files
Documentation
endpoints.zh-cn.md
Enhanced Chinese translation for Grid endpoints documentation

website_and_docs/content/documentation/grid/advanced_features/endpoints.zh-cn.md

  • Improved translation for better readability and clarity.
  • Updated terminology for consistency across the document.
  • Enhanced descriptions of commands and their usage.
  • Fixed formatting and punctuation issues.
  • +38/-80 

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Apr 4, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 580ac07

    @CLAassistant
    Copy link

    CLAassistant commented Apr 4, 2025

    CLA assistant check
    All committers have signed the CLA.

    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 4, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Section Replacement

    The PR replaces the "检查会话所有者" (Check Session Owner) section with a new "删除会话" (Delete Session) section. This might be unintentional as both sections should exist separately in the document.

    ### 删除会话
    
    删除会话会终止 WebDriver 会话、退出驱动程序并将其从活动会话映射中删除。任何使用删除的会话标识或重新使用驱动程序实例的请求都会出错。
    Terminology Consistency

    The PR changes "放空节点" to "释放节点" in multiple places. Need to verify this is the correct terminology in Chinese and that it's consistently applied throughout the document.

    ### 释放节点
    
    节点释放命令用于优雅地关闭节点。在所有正在进行的会话结束后,会停止该节点。并且,它不会接受任何新的会话请求。

    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 4, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix header syntax error

    There's a syntax error in the header parameter. The X-REGISTRATION-SECRET header
    is missing a value. It should either be 'X-REGISTRATION-SECRET:' (with no space
    after the colon) or completely removed if no secret is needed.

    website_and_docs/content/documentation/grid/advanced_features/endpoints.zh-cn.md [62]

    -cURL --request DELETE 'http://<Router-URL>/se/grid/distributor/node/<node-id>' --header 'X-REGISTRATION-SECRET;'
    +cURL --request DELETE 'http://<Router-URL>/se/grid/distributor/node/<node-id>' --header 'X-REGISTRATION-SECRET:'
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies a syntax error in the header parameter where 'X-REGISTRATION-SECRET;' is missing a proper value format. This fix is important as it would prevent API request failures when users copy and use these commands.

    Medium
    General
    Fix incorrect terminology
    Suggestion Impact:The commit implemented the suggestion by changing 'Hub 器' to 'Hub' on line 10 of the diff, exactly as suggested

    code diff:

    -在 Hub-Node 模式下, 分发器 URL 是 Hub 器服务器的地址。
    +在 Hub-Node 模式下, 分发器 URL 是 Hub 服务器的地址。

    The term "Hub 器" appears to be a translation error. It should be just "Hub"
    without the redundant "器" character which means "device" or "machine" in
    Chinese.

    website_and_docs/content/documentation/grid/advanced_features/endpoints.zh-cn.md [50]

    -在 Hub-Node 模式下, 分发器 URL 是 Hub 器服务器的地址。
    +在 Hub-Node 模式下, 分发器 URL 是 Hub 服务器的地址。

    [Suggestion has been applied]

    Suggestion importance[1-10]: 7

    __

    Why: The suggestion correctly identifies a translation error where "Hub 器" is used instead of just "Hub". This improves terminology consistency and readability in the Chinese translation, making the documentation more professional and easier to understand.

    Medium
    • Update

    @alaahong
    Copy link
    Member

    alaahong commented Apr 6, 2025

    Thanks for your first contribution. Can you try to follow below guide on your submit? It's better to wrap your lines.
    https://www.selenium.dev/documentation/about/contributing/#step-4-commit

    @alaahong
    Copy link
    Member

    alaahong commented Apr 6, 2025

    Please also sign the CLA before raise the PR, it will be blocking as default workflow checker.
    image

    HandyCC added 2 commits April 9, 2025 23:55
    Improve the content of Chinese translation.
    
    Fixes to issues arising from the last submit.
    Improve the content of Chinese translation.
    
    Fixes to issues arising from the last submit.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants