This repository was archived by the owner on Oct 5, 2026. It is now read-only.
Repository navigation
Conversation
- Fix 66 eslint errors (import order, unused vars, strict-boolean, eqeqeq, etc.) - Remove environment: npm from publish workflow (not configured on npm side)
There was a problem hiding this comment.
Pull request overview
This PR updates the repo to pass ESLint/format checks while completing the svp → forge rename across the CLI surface area (commands, prompts, docs, tests) and tweaks the publish workflow to align with npm Trusted Publishing.
Changes:
- Rename CLI/program references from
svptoforgeacross prompts, adapters, docs, and tests. - Tighten typings / lint fixes (import order, unused vars, strict-boolean, etc.) and add extra CI smoke checks.
- Adjust publish workflow by removing
environment: npm.
Reviewed changes
Copilot reviewed 65 out of 66 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/svp-workflow.ts | Updates E2E workflow labeling/examples from svp to forge. |
| tests/e2e/svp-workflow-zh.ts | Same as above for Chinese E2E workflow. |
| tests/e2e/design-l3-all-kinds.ts | Updates command reference in test header comment. |
| packages/skills/templates/slash-commands.ts | Updates slash command template comments to /forge. |
| packages/skills/templates/claude-md.ts | Updates CLAUDE.md integration comment to forge init. |
| packages/skills/rehash.ts | Updates skill doc comment to forge rehash. |
| packages/skills/prompts/update-ref.ts | Updates prompt instructions to forge rehash/check. |
| packages/skills/prompts/review.ts | Updates prompt module header to forge. |
| packages/skills/prompts/recompile.ts | Updates prompt instructions to forge link. |
| packages/skills/prompts/design-l5.ts | Updates prompt instructions to forge rehash/view and import order. |
| packages/skills/prompts/design-l4.ts | Updates prompt instructions to forge rehash/view and import order. |
| packages/skills/prompts/design-l4-state-machine.ts | Updates prompt instructions to forge rehash/view and import order. |
| packages/skills/prompts/design-l4-event-graph.ts | Updates prompt instructions to forge rehash/view and import order. |
| packages/skills/prompts/design-l3.ts | Updates prompt instructions to forge rehash/view and import order. |
| packages/skills/prompts/compile.ts | Updates prompt instructions to forge link. |
| packages/skills/prompt-builder.ts | Updates output spec/rules strings to forge and import ordering. |
| packages/skills/link.ts | Updates skill doc comment to forge link. |
| packages/skills/adapters/windsurf.ts | Import ordering cleanup. |
| packages/skills/adapters/types.ts | Changes interface method syntax to function-typed properties. |
| packages/skills/adapters/shared.ts | Updates protocol/workflow content to forge and tightens frontmatter conditional. |
| packages/skills/adapters/kimi-code.ts | Import ordering cleanup. |
| packages/skills/adapters/index.ts | Import ordering and stricter getAdapter undefined handling. |
| packages/skills/adapters/github-copilot.ts | Import ordering cleanup. |
| packages/skills/adapters/detect.ts | Type tweak for host markers array. |
| packages/skills/adapters/cursor.ts | Import ordering cleanup. |
| packages/skills/adapters/codex.ts | Import ordering cleanup. |
| packages/skills/adapters/claude-code.ts | Import ordering cleanup. |
| packages/skills/tests/prompt-builder.test.ts | Updates expectation to forge link. |
| packages/skills/tests/design-prompts.test.ts | Import ordering cleanup. |
| packages/skills/tests/adapters.test.ts | Test refactors + workflow consistency helper extracted. |
| packages/core/view.ts | Updates header comment and silences unused lang parameters. |
| packages/core/l3.ts | Updates comment reference to forge check. |
| packages/core/i18n.ts | Updates CLI message strings to forge and tightens env handling/typing. |
| packages/core/i18n.test.ts | Updates tests for optional getLanguage/helper defaults. |
| packages/core/compile-plan.ts | Updates header comment and switch-case block formatting. |
| packages/core/compile-plan.test.ts | Regex tweak for Unicode range literal. |
| packages/core/check.ts | Updates header comment to forge check. |
| packages/cli/index.ts | Renames CLI program to forge and tweaks import ordering. |
| packages/cli/commands/view.ts | Updates view command docs/messages to forge. |
| packages/cli/commands/rehash.ts | Updates command docs/output prefix to forge. |
| packages/cli/commands/rehash.test.ts | Updates test suite description to forge rehash. |
| packages/cli/commands/prompt.ts | Updates prompt command docs/errors to forge and import ordering. |
| packages/cli/commands/prompt.test.ts | Updates test suite description and expected output to forge link. |
| packages/cli/commands/link.ts | Updates command docs to forge link. |
| packages/cli/commands/link.test.ts | Updates test suite description to forge link. |
| packages/cli/commands/init.ts | Updates command docs to forge init and refactors host selection logic. |
| packages/cli/commands/init.test.ts | Updates test suite description to forge init. |
| packages/cli/commands/fix.ts | Updates command docs/errors to forge and tightens string conversions. |
| packages/cli/commands/compile-plan.ts | Updates command docs/output prefix and messages to forge. |
| packages/cli/commands/check.ts | Updates command docs/output prefix and messages to forge. |
| packages/cli/commands/check.test.ts | Updates test suite description to forge check. |
| package-lock.json | Renames package/bin to @svporg/forge/forge and adds license field. |
| docs/tutorial.md | Updates tutorial commands to @svporg/forge and forge .... |
| docs/project-introduction.md | Updates CLI command references/headings to forge. |
| docs/phase2-plan.md | Updates planning doc command references to forge. |
| docs/overview.md | Updates overview doc command references to forge. |
| docs/node-spec.md | Updates spec doc command references to forge. |
| docs/interaction.md | Updates interaction doc command references to forge. |
| docs/design.md | Updates design doc command references to forge. |
| docs/design-rationale.md | Updates design rationale command references to forge. |
| docs/compilation.md | Updates compilation doc command references to forge. |
| docs/check-reference.md | Renames check reference doc to forge check. |
| docs/architecture.md | Updates architecture doc command references to forge. |
| README.md | Updates README command references to forge. |
| .github/workflows/publish.yml | Removes environment: npm for Trusted Publishing alignment. |
| .github/workflows/ci.yml | Adds post-build CLI checks against example projects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| 用户决定： | ||
| a. 接受 L1 的改动 → svp accept l2/validate-order → 更新 contentHash | ||
| a. 接受 L1 的改动 → forge accept l2/validate-order → 更新 contentHash |
Comment on lines
37
to
38
| const lang = options.language ?? "en"; | ||
|
|
| .name("svp") | ||
| .name("forge") | ||
| .description("SVP — Semantic Voxel Protocol toolchain") | ||
| .version("0.1.0"); |
Comment on lines
30
to
31
| export function getLanguage(l5?: Pick<L5Blueprint, "language"> ): string { | ||
| return l5?.language ?? detectSystemLanguage(); |
Comment on lines
+188
to
192
| 查看器**只读不写**。编辑是 AI 的事（通过 `forge view` + `forge edit` 操作数据）。查看器只是让人能看懂 AI 在操作什么。 | ||
|
|
||
| - **svp-blueprint**（蓝图查看器）：L4/L3 的可视化节点图。把 flow 的步骤编排和 block 之间的数据流渲染成节点和连线，让人一眼看到全局拓扑。人在这个视图里理解系统结构，但不直接在图上编辑——要改的话，在对应层级告诉 AI 去改。 | ||
| - **CLI 查看器**：`svp status` 展示各层的健康状态（哪些 hash 匹配、哪些有 drift）。文本界面，适合快速检查。 | ||
| - **CLI 查看器**：`forge status` 展示各层的健康状态（哪些 hash 匹配、哪些有 drift）。文本界面，适合快速检查。 | ||
| - **未来可以有更多查看器**：Web dashboard、IDE 插件、移动端概览。底下读的是同一份数据，只是渲染方式不同。 |
Comment on lines
+159
to
+160
| 2. forge edit l4/create-order ← 在 validate-order 后加 rate-limit 步骤 | ||
| 3. forge compile-plan ← SVP 计算变更范围 |
- Add contributing guide with dev setup, PR workflow, commit conventions - Add Contributor Covenant v2.1 Code of Conduct - Whitelist new files in .gitignore
xycld
added a commit
that referenced
this pull request
Mar 18, 2026
Fix lint errors and publish workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment: npmfrom publish workflow to match npm Trusted Publishing configVerification
npm run lintpasses with 0 errorsv0.1.1to trigger publish