Update benchmark_serving.py#1705
Open
puneithk wants to merge 1 commit into
Open
Conversation
We need to have input and output token length for performance tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to have input and output token length for performance tracking.
Note
Low Risk
Single change to which JSON fields are dropped on save; no runtime serving or benchmark execution behavior changes.
Overview
Keeps per-request token lengths in default benchmark JSON exports so performance tracking can use them without turning on full detailed dumps.
When
--save-resultis used and--save-detailedis not, the saver still strips high-volume fields (ttfts,itls,generated_texts,errors) to limit file size, but it no longer removesinput_lensandoutput_lensfrom the merged result.Reviewed by Cursor Bugbot for commit 7a260a1. Bugbot is set up for automated code reviews on this repo. Configure here.