-
Notifications
You must be signed in to change notification settings - Fork 4
ATGC 염기서열 입력 검증 및 자동 대문자 변환 기능 추가 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7d84974
feat: ATGC 외의 문자 입력 시 경고 메시지 표시 및 재입력 요구. 해당 문자 입력 시 자동 대문자 변환 기능 추가
cnvxlns b695f65
fix: harden lint/build pipeline and fix Turbopack module resolution
cnvxlns 4647dc7
fix: paste시 atgc외 문자 정제 및 제출 전 ATGC 검증 추가
cnvxlns eb7a67f
fix: paste시 atgc외 문자 정제 및 제출 전 ATGC 검증 추가
cnvxlns fa928e4
feat: 붙여넣기/업로드 시 잘못된 염기 필터링 전 확인 팝업 추가
cnvxlns 5b30ad5
fix: 입력 변경 폴백 sanitize 적용 및 생성 전 중복 검증 제거
cnvxlns cceb44c
fix: 멘트 두 줄로 줄바꿈
cnvxlns 68c6ccb
fix: Step1 유효성 검증 중복 제거 및 목적별 분기 명확화
cnvxlns 8b120d2
fix: confirm 취소 시 기본 Ctrl+V 동작 유지하도록 preventDefault 순서 수정
cnvxlns d8d8543
refactor: Step1 경고 노출 경로 분리로 중복 메시지 제거
cnvxlns 747f7c8
refactor: 미사용 toUpperCaseAtgcOnly 제거 및 관련 테스트 정리
cnvxlns ce55768
chore: 미사용 isUppercaseAtgcOnlySequence 제거 및 테스트 정리
cnvxlns 15263d2
chore: Paste/Ctrl+V/Upload 문자 제거 확인을 커스텀 다이얼로그로 통일
cnvxlns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용자가 Step 1에서 다음 단계로 이동할 때와 Generate 버튼을 클릭할 때 중복된 검증 로직이 실행됩니다.
handleNext(88번 줄)와handleGenerate(105-113번 줄) 모두에서 유효성 검증을 수행하는데, 이는 일관성이 부족하고 유지보수를 어렵게 만듭니다. 검증 로직을 한 곳에서 수행하거나, 각각의 검증 목적이 다르다면 주석으로 명확히 구분해 주세요.