Refactor overflow options into separate options #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
OverflowModeoption into two separate options:DataType, for choosing the data type of a state machineExecutionOptions, for choosing things such as overflowThis better decouples the options from the machine state and makes it easier to do more refactoring to switch to all the new .NET stuff in future PRs. The previous organization was awkward because it tied additional options (eg. overflow) to a given state machine, despite those options having no effect on the actual memory state of a given state machine.
With this change, only options actually impacting the memory layout have to be carried around as part of a state machine.