Bump toml_edit to 0.25 - #155
Open
glamberson wants to merge 1 commit into
Open
Conversation
toml_edit 0.22 is two years old. The latest stable is 0.25.11. The bump is a one-line Cargo.toml change: the `parse` and `serde` features Figment uses and the `toml_edit::de::from_str` call in src/providers/data.rs are stable across 0.22 -> 0.25, so no source changes are required. PR SergioBenitez#145 (open since 2025-07-22) proposed a bump to 0.23. This PR supersedes that one by going to the latest stable 0.25 instead. Verified: cargo build --all-features cargo test --all-features (143 passed, 0 failed) Note: cargo clippy --all-features --all-targets -- -D warnings shows 48 pre-existing `result_large_err` errors on master that are unrelated to this change. The bump itself introduces no new clippy findings.
|
This was referenced Apr 20, 2026
Author
|
@lmmx thanks for mirroring it to figment2 and cutting v0.11.5. Appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
toml_editfrom 0.22 (two years old) to the latest stable 0.25.11.The
parseandserdefeatures used here, and the single call sitetoml_edit::de::from_strinsrc/providers/data.rs, are stable across 0.22 through 0.25. One-line Cargo.toml change, no source edits required.Verification
cargo build --all-features: cleancargo test --all-features: 143 passed, 0 failedcargo clippy --all-features --all-targets -- -D warningsshows 48 pre-existingresult_large_errerrors on master. Those are unrelated to this change and reproducible on vanillamaster.Relation to PR #145
This PR supersedes #145 (by @Krysztal112233, open since 2025-07-22), which proposed the same bump to 0.23. Going straight to 0.25 avoids a second bump PR later. #145 can be closed in favour of this one.
Context
The published 0.10.19 crate still depends on
toml = "0.8", which blocks downstream migrations totoml 0.9(notably the current Debian Rust team transition tracked at debcargo-conf issue #147). Master has already switched totoml_edit, but the unreleased state means the transition is effectively stuck behind a future release. Merging this bump and cutting a release resolves the downstream friction cleanly.