Minor fixes (#281)

ServiceNow · Nov 27, 2024 · f21ede0 · f21ede0
1 parent 9b360a8
commit f21ede0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/browsergym/core/src/browsergym/core/env.py b/browsergym/core/src/browsergym/core/env.py
@@ -244,7 +244,7 @@ def override_property(task, env, property):
         # create a new browser context for pages
         self.context = self.browser.new_context(
             no_viewport=True if self.resizeable_window else None,
-            viewport=viewport,
+            viewport=viewport if not self.resizeable_window else None,
             record_video_dir=(
                 Path(self.record_video_dir) / "task_video" if self.record_video_dir else None
             ),

diff --git a/browsergym/core/src/browsergym/core/task.py b/browsergym/core/src/browsergym/core/task.py
@@ -12,9 +12,8 @@ class AbstractBrowserTask(ABC):
     """
 
     @classmethod
-    @abstractmethod
     def get_task_id(cls):
-        pass
+        raise NotImplementedError
 
     def __init__(self, seed: int) -> None:
         # initiate a random number generator