Skip to content

Sampling parameters, generalize batch config. #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

Conversation

jlamypoirier
Copy link
Collaborator

✨ Description

Deal with some structural issues and technical debt causing trouble for ongoing work.

🔍 Type of change

Select all that apply:

  • 🐛 Bug fix (non-breaking change that addresses a specific issue)
  • 🚀 New feature (non-breaking change that adds functionality)
  • ⚠️ Breaking change (a change that could affect existing functionality)
  • 📈 Performance improvement/optimization (improves speed, memory usage, or efficiency)
  • 🛠️ Code refactor (non-functional changes that improve code readability, structure, etc.)
  • 📦 Dependency bump (updates dependencies, including Dockerfile or package changes)
  • 📝 Documentation change (updates documentation, including new content or typo fixes)
  • 🔧 Infrastructure/Build change (affects build process, CI/CD, or dependencies)

@jlamypoirier jlamypoirier marked this pull request as ready for review April 15, 2025 20:32
@tscholak
Copy link
Collaborator

I think the most interesting and valuable change here is actually that with this we can now set these so-called sampling parameters differently for different datasets.

@jlamypoirier jlamypoirier requested a review from tscholak April 16, 2025 14:45
Copy link
Collaborator

@tscholak tscholak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlamypoirier jlamypoirier merged commit 01b71c9 into main Apr 16, 2025
4 checks passed
@jlamypoirier jlamypoirier deleted the sampling_parameters branch April 16, 2025 15:52
This was referenced Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants