Fix triton cross-entropy for large vocab sizes, support tensor-parallel#466
Draft
jlamypoirier wants to merge 7 commits intojlp_entropy_loss_tweaksfrom
Draft
Fix triton cross-entropy for large vocab sizes, support tensor-parallel#466jlamypoirier wants to merge 7 commits intojlp_entropy_loss_tweaksfrom
jlamypoirier wants to merge 7 commits intojlp_entropy_loss_tweaksfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Add looped and TP implementations of cross-entropy loss. Turns out the 64K vocab limitation is gone, but going higher makes the kernels way slower, so looped is still better. (Above 32K actually)
Test benchmark (8K tokens, cuda time + est. memory usage):