Skip to content

Delete duplicate check for script in acl #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Delete duplicate check for script in acl #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 126 additions & 0 deletions ...62c3b24bcbaa/author_elective_update/scan_table_check_eb21adf797697110710650081153af9c.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
<scan_table_check action="DELETE">
<active>true</active>
<advanced>false</advanced>
<category>security</category>
<conditions table="sys_security_acl">scriptISNOTEMPTY^advanced=false^EQ<item endquery="false" field="script" goto="false" newquery="false" operator="ISNOTEMPTY" or="false" value=""/>
<item endquery="false" field="advanced" goto="false" newquery="false" operator="=" or="false" value="false"/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Script in ACL executes even if Advanced is unchecked. This may lead to confusion and unexpected behavior, coming from the script being hidden on the form but executed.</description>
<documentation_url>https://docs.servicenow.com/bundle/utah-platform-security/page/administer/contextual-security/task/t_CreateAnACLRule.html</documentation_url>
<finding_type>scan_finding</finding_type>
<name>Script in ACL when Advanced is unchecked</name>
<priority>1</priority>
<resolution_details>Either check Advanced or Remove the script from the ACL, while making sure to maintain the same ACL result.</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

// Add your code here

})(engine);]]></script>
<short_description>Script in ACL executes even if Advanced is unchecked.</short_description>
<sys_class_name>scan_table_check</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2023-10-04 20:36:19</sys_created_on>
<sys_id>eb21adf797697110710650081153af9c</sys_id>
<sys_mod_count>0</sys_mod_count>
<sys_name>Script in ACL when Advanced is unchecked</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_table_check_eb21adf797697110710650081153af9c</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2023-10-04 20:36:19</sys_updated_on>
<table>sys_security_acl</table>
<use_manifest>false</use_manifest>
</scan_table_check>
<sys_update_version action="INSERT_OR_UPDATE">
<action>DELETE</action>
<application display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</application>
<file_path/>
<instance_id>7c7abcb4db5631d82f082a5913961914</instance_id>
<instance_name>dev200172</instance_name>
<name>scan_table_check_eb21adf797697110710650081153af9c</name>
<payload>&lt;?xml version="1.0" encoding="UTF-8"?&gt;&lt;record_update table="scan_table_check"&gt;
&lt;scan_table_check action="INSERT_OR_UPDATE"&gt;
&lt;active&gt;true&lt;/active&gt;
&lt;advanced&gt;false&lt;/advanced&gt;
&lt;category&gt;security&lt;/category&gt;
&lt;conditions table="sys_security_acl"&gt;scriptISNOTEMPTY^advanced=false^EQ&lt;item endquery="false" field="script" goto="false" newquery="false" operator="ISNOTEMPTY" or="false" value=""/&gt;
&lt;item endquery="false" field="advanced" goto="false" newquery="false" operator="=" or="false" value="false"/&gt;
&lt;item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/&gt;
&lt;/conditions&gt;
&lt;description&gt;Script in ACL executes even if Advanced is unchecked. This may lead to confusion and unexpected behavior, coming from the script being hidden on the form but executed.&lt;/description&gt;
&lt;documentation_url&gt;https://docs.servicenow.com/bundle/utah-platform-security/page/administer/contextual-security/task/t_CreateAnACLRule.html&lt;/documentation_url&gt;
&lt;finding_type&gt;scan_finding&lt;/finding_type&gt;
&lt;name&gt;Script in ACL when Advanced is unchecked&lt;/name&gt;
&lt;priority&gt;1&lt;/priority&gt;
&lt;resolution_details&gt;Either check Advanced or Remove the script from the ACL, while making sure to maintain the same ACL result.&lt;/resolution_details&gt;
&lt;run_condition/&gt;
&lt;score_max&gt;100&lt;/score_max&gt;
&lt;score_min&gt;0&lt;/score_min&gt;
&lt;score_scale&gt;1&lt;/score_scale&gt;
&lt;script&gt;&lt;![CDATA[(function (engine) {

// Add your code here

})(engine);]]&gt;&lt;/script&gt;
&lt;short_description&gt;Script in ACL executes even if Advanced is unchecked.&lt;/short_description&gt;
&lt;sys_class_name&gt;scan_table_check&lt;/sys_class_name&gt;
&lt;sys_created_by&gt;admin&lt;/sys_created_by&gt;
&lt;sys_created_on&gt;2023-10-04 20:36:19&lt;/sys_created_on&gt;
&lt;sys_id&gt;eb21adf797697110710650081153af9c&lt;/sys_id&gt;
&lt;sys_mod_count&gt;0&lt;/sys_mod_count&gt;
&lt;sys_name&gt;Script in ACL when Advanced is unchecked&lt;/sys_name&gt;
&lt;sys_package display_value="Example Instance Checks" source="x_appe_exa_checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_package&gt;
&lt;sys_policy/&gt;
&lt;sys_scope display_value="Example Instance Checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_scope&gt;
&lt;sys_update_name&gt;scan_table_check_eb21adf797697110710650081153af9c&lt;/sys_update_name&gt;
&lt;sys_updated_by&gt;admin&lt;/sys_updated_by&gt;
&lt;sys_updated_on&gt;2023-10-04 20:36:19&lt;/sys_updated_on&gt;
&lt;table&gt;sys_security_acl&lt;/table&gt;
&lt;use_manifest&gt;false&lt;/use_manifest&gt;
&lt;/scan_table_check&gt;
&lt;/record_update&gt;</payload>
<payload_hash>1356454248</payload_hash>
<record_name>Script in ACL when Advanced is unchecked</record_name>
<reverted_from/>
<source>f587d90bc3dd1250faa4bd33e4013147</source>
<source_table>sys_upgrade_history</source_table>
<state>previous</state>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2024-10-21 18:01:38</sys_created_on>
<sys_id>2387514bc3dd1250faa4bd33e40131fe</sys_id>
<sys_mod_count>0</sys_mod_count>
<sys_recorded_at>192b03de1990000001</sys_recorded_at>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2024-10-21 18:01:38</sys_updated_on>
<type>Table Check</type>
<update_guid>2f87514b95dd1250d8d7157d4a5955fd</update_guid>
<update_guid_history>2f87514b95dd1250d8d7157d4a5955fd:0,e267d9c752dd1250e0ae7bf3aa17e665:-2023533997,eea83dedc1c5de50dcb00ddc90e599ae:1356454248</update_guid_history>
</sys_update_version>
<sys_metadata_delete action="INSERT_OR_UPDATE">
<sys_audit_delete display_value="Script in ACL when Advanced is unchecked">1379110bc3dd1250faa4bd33e4013183</sys_audit_delete>
<sys_class_name>sys_metadata_delete</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2024-10-21 18:10:05</sys_created_on>
<sys_db_object display_value="" name="scan_table_check">scan_table_check</sys_db_object>
<sys_id>6497f98bb9dc40a28cfd0e9f7ed83e24</sys_id>
<sys_metadata>eb21adf797697110710650081153af9c</sys_metadata>
<sys_mod_count>0</sys_mod_count>
<sys_name>Script in ACL when Advanced is unchecked</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_parent/>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_scope_delete display_value="">30a78b9b9290467a96959a65d2b2d304</sys_scope_delete>
<sys_update_name>scan_table_check_eb21adf797697110710650081153af9c</sys_update_name>
<sys_update_version display_value="scan_table_check_eb21adf797697110710650081153af9c">2387514bc3dd1250faa4bd33e40131fe</sys_update_version>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2024-10-21 18:10:05</sys_updated_on>
</sys_metadata_delete>
</record_update>
2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
BgiovevC1ze9ekbSNu313pR_3YPr9xUl8hAleZQ_Rnfiowfr5T_DAmii6h_xnZewjTA5kJDPZ8x14S0gIPG4eStZ_r0uGIAEaMA2i5ojlbIKORDDapgOMutOHKJaSSwf5uZ0VkEcLzooGIDWB0v16daIWWmH_U_tcnLaTE7bj5lyq4EtAk53xdL2hPu7eGFz949_eZIJg4np37S0xRegM9y_dmXRrQ8sLopLNT_af4u_BCPeNIg9Gwq5Wjn9Qj-xbi8bazd-3t7Koe2HKHH2vqOryT-dhuZufc9zUI_l55ev-4cGovoOeBX2wc13EwKh1HIMaW9kwiWljZ-0An9_loh6WU6FYCcnEV9xS2xDXUbHOoWeuOdg76lvyor5qfEN3jOQ46xXIoW5vidkXaoBVtMSLMcBFbrFBZuJWI0Zq4lZU6TiRvzbveuo1rDeAv126QIJhGCuE0SDcvzuV96dbttSOQ-ZgAUumexHi91tJ_97V2MDP9q5Ms-5Y0Mg9r0PNqCibJqaPEnkxgYPIYePZZZdYPYWbOtM4eTteRkWZxAXO_lRTEq7Bon9z0cpiIRBaZLIg7LiMeLZk8F2gHservOdv1_Y1D_rFznoMifC65doHeUJMmIqw6u6vCAM7C9B8YpsXDLWfL6sPrSqTQwVK1WHG_lmjTI_4U6Qb1fAgFg
ZxSMaYqpl9pnshBDUJXNxd1Rokl_u8HcysRfwGusYrrj1ELNlQnrWVagO5RWsJa_SXgxaC7NOAC7JeAmr2Yh_2cjbsJc0p1LLuV4FenYljd6t0myBjtd6JL8iAxD-HJNVj7UOo1PeeBCudWYR9GIfV44li7iLWbgfFg1mKWQJVByfPK1YMckO3QxnBjGUnYqj39KWBF0jxyAs3QDC0GEXEpF67dg85r00xTjWQg2iWP-L_m9oA0Nkp_4EZ47lhQs463j8kXaBKHzxQW-jFofVlJyJb3LwoX9BxV4SE4tfEViNdCjxFhxAKDuCqLJzTUvIbeoz8V3b-xSl_K8cEFwtzFmdQ6-wBLWhluYEBFsLiSp_lLyW-mWCsDPJg5h6MtbGTKfZta6LcbJwm89M_IhiUfBlg9KMzbZzJ1Q44nr-nHDANM9H1fNzy9thDr-OAsbVTCahF5NhofxI7mDqnesJAbzVslzWULRpie4mUVljWpe3_z6dlTdRYPpdF0suX6D0HI-rNd7ZiZXvMbhNHBmaLSiDVRgeWj7R-YBEsUSUWHGinybIv8TQXYnIqjipFvFHIXQ2kiQVFEfeOxhHRMg2Ox4QfQ01rWWrwWL8cZpH5PHoy-FVzpzujsqC9OS5MHFdPT7n-NTNeCp34xU3dMV40tJODCzC32V79N2FCLH4Pw
41 changes: 0 additions & 41 deletions ...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_eb21adf797697110710650081153af9c.xml
View file
Open in desktop

This file was deleted.

Loading