Code cleanup: format with Black, add docstrings, improve error handling#159
Open
morningstarxcdcode wants to merge 1 commit intoSesameAILabs:mainfrom
Open
Code cleanup: format with Black, add docstrings, improve error handling#159morningstarxcdcode wants to merge 1 commit intoSesameAILabs:mainfrom
morningstarxcdcode wants to merge 1 commit intoSesameAILabs:mainfrom
Conversation
ZackHodari
requested changes
Jun 16, 2025
Collaborator
ZackHodari
left a comment
There was a problem hiding this comment.
If this PR was just the black linting then we could land it. See note below about CI/CD
- try-except with generic Exception does not add utility, especially for a CLI tool like this repo
- I'd prefer to follow the clean code principle of better naming rather than adding comments. Some of your comments also remove previous notes that were valuable
- I appreciate the black linting, we could land this but feels like bad practice to do so without adding CI/CD to enforce this on future commits. This repo is unlikely to change much so seems like it's not that useful an endeavor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this repo is with no erros best bro
but I am making the codebase cleaner and more reliable:
basically just enchanted the files no thing more ok yes....