Fix issues around new _version.py file

SethMMorton · Oct 9, 2024 · 3391dd2 · 3391dd2
1 parent 6e818d4
commit 3391dd2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
@@ -55,7 +55,10 @@ jobs:
           python-version: '3.8'
 
       - name: Install MyPy
-        run: pip install mypy hypothesis pytest pytest-mock fastnumbers
+        run: pip install mypy hypothesis pytest pytest-mock fastnumbers setuptools_scm
+
+      - name: Create _version.py file
+        run: python -m setuptools_scm --force-write-version-files
 
       - name: Run MyPy
         run: mypy --strict natsort tests

diff --git a/dev/clean.py b/dev/clean.py
@@ -38,4 +38,4 @@
 # Remove _version.py
 version = pathlib.Path("natsort/_version.py")
 if version.is_file():
-    f.unlink()
+    version.unlink()
diff --git a/natsort/__init__.py b/natsort/__init__.py
@@ -1,5 +1,7 @@
 try:
-    from natsort._version import __version__, __version_tuple__
+    # The redundant "as" tells mypy to treat as explict import
+    from natsort._version import __version__ as __version__
+    from natsort._version import __version_tuple__ as __version_tuple__
 except ImportError:
     __version__ = "unknown version"
     __version_tuple__ = (0, 0, "unknown version")