Release AEI REV A Design

[mohamed-dek1]

Closes #276, Closes #277

Notes

Anything reviewers should be aware of when reviewing? Other related issues? Known problems? Future work?

Self-Review

1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
3. Do all Markdown files follow the CONTRIBUTING article template? No: Some markdown files follow the PCB Release template
4. Do all links work in the material that the PR is adding? Yes
5. Is the PR configured to close the correct issue(s)? Yes
6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

• Report checklist
• Publication archive checklist (select a checklist from the Approach that corresponds to the step this PR seeks to complete).
• Standard checklist (if none of the above apply).

Standard checklist

1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

[mohamed-dek1]

@elsevers, can you review this?

[elsevers]

Thanks @mohamed-dek1. I am looking at this image and think we need to make some corrections to the plots on the bottom:

The y axis labels on the plots on the bottom don't make any sense (at the very least, they seam to have units of amps instead of volts...)

From Tim / @mhmokhtarabadi's report here it looks like:

• the left plot should show: a sine wave of amplitude 0.25V and offset 1.6V
• the right plot should show: a sine wave of amplitude 2.5V and no offset

[mohamed-dek1]

@elsevers, I've gone and updated the diagram to show the correct plots. Below is the attached graph that I will be using to update the docs. Can you review this?

[elsevers]

Thanks @mohamed-dek1. It looks like voltage offset values are wrong (should be 1.6V, not 1.5V). Also, the plots you added on the bottom are too heavily scaled to be useful. I recommend rendering these at the right size before you copy-paste.

At this point, it's probably easiest to script the whole thing following these instructions: https://github.com/Severson-Group/KnowledgeBase/blob/main/code/matlab/README.md#plots

Note the instructions to set the plot size up to be the size you want it to be in your graphic (to avoid the kind of scaling issues we have here)

[mohamed-dek1]

@elsevers, can you review this PR and take a look at the new diagram?

[elsevers]

Hi @mohamed-dek1-- thanks. You were going to attach the source to your comment so I can edit. Can you please do this?

• "AMDC" text is a different color
• "Single ended signal" text is a different color and size than other labels of this type
• Remove $\omega label from the plot on the top right
• The + - and PLL labels in the AMDC box are different size than in the other boxes
• The pots on the bottom are still too small / scaled

[mohamed-dek1]

@elsevers, the zip file below has both the graph and the script I used to create them. I also have the PowerPoint slide deck attached below.

aei-diagram-creation.zip
ME4090BlockDiagrams.pptx