Add autogen for AMDC article in control with AMDC folder#151
Add autogen for AMDC article in control with AMDC folder#151Daehoon-Sung wants to merge 25 commits intomainfrom
Conversation
Refine the introduction and workflow sections for clarity and conciseness. Improve the structure and language for better readability.
Updated the documentation to clarify the workflow and integration details for Simulink models with AMDC, including code generation and organization.
This update enhances the documentation by providing a detailed explanation of the Simulink Autogen workflow and its integration with the AMDC. It includes sections on the example model, system-level representation, generated code structure, and the role of the example as a reference implementation.
Revised the example model section to clarify the Simulink Autogen workflow and its integration with the AMDC. Updated descriptions for the Simulink model structure and generated code structure.
Clarified the Autogen capability description and added details about file path constraints.
Updated image syntax for autogen example block diagram.
Removed redundant lines in the conclusion section.
|
Since this is not a report but an article, I used the
Please work on addressing any No items. |
|
Hello Dr @noguchi-takahiro. Could you review this article? I tried to implement the feedback thoroughly and make the article neat. Let me know if you have any feedback. Thank you! From the issue here, or the comment from Professor here,
I followed the structure of the
This item 1 is covered in:
This item 2 is covered in:
This item 3 is covered in:
This item 4 is covered in:
This item 5 is covered in:
|
Clarified the structure of generated code and execution model for Simulink Autogen. Removed redundant information and improved readability.
Updated the documentation to include the control algorithm function in the appropriate section.
|
Hello Dr @noguchi-takahiro. This is a friendly reminder for this PR review. Thank you. |
noguchi-takahiro
left a comment
There was a problem hiding this comment.
Thank you @Daehoon-Sung. Nice article. The content looks good, and I have several suggestions intended to reduce redundancy. Could you consider addressing these below?
| ``` | ||
| apps/ | ||
| └── my_app/ | ||
| ├── src/ | ||
| ├── include/ | ||
| └── autogen/ | ||
| └── modelName_ert_rtw/ | ||
| ``` |
There was a problem hiding this comment.
We should discuss this folder configuration, but a promising configuration is like this:
control/
|-- my_c_code/
| |-- usr/
| |-- my_app/
| |-- autogen/
| |-- modelName.c
| |-- modelName.h
| |-- ...
There was a problem hiding this comment.
Thank you @noguchi-takahiro. I revised it.
There was a problem hiding this comment.
Let's discuss this during our meeting @noguchi-takahiro.
Co-authored-by: Takahiro <114006024+noguchi-takahiro@users.noreply.github.com>
Co-authored-by: Takahiro <114006024+noguchi-takahiro@users.noreply.github.com>
Co-authored-by: Takahiro <114006024+noguchi-takahiro@users.noreply.github.com>
Co-authored-by: Takahiro <114006024+noguchi-takahiro@users.noreply.github.com>
Co-authored-by: Takahiro <114006024+noguchi-takahiro@users.noreply.github.com>
Add section on development environment and workflow requirements.
Updated directory structure for autogenerated files in AMDC repository.
Removed integration notes and consolidated file constraints for clarity.
|
Hello @noguchi-takahiro. I have changed the folder structure here, as you told me. Additionally, I have addressed all the feedback. Thank you. Do you think we can ask review from Professor @elsevers, or do you want to discuss the folder structure together first? |
|
Thank you.
This sounds good, while discussing the file configuration. |
|
Hello Professor @elsevers. Regarding this comment, we created an article that includes "Control with AMDC" article on Autogen. Could you review this article, Professor? |
|
Hello Professor @elsevers. This is a friendly reminder. Could you review this article when you have time? |
|
Hello Professor @elsevers. This is a friendly reminder. Could you review this article when you have time? |
This is to close issue #149.
Notes
Anything reviewers should be aware of when reviewing? Other related issues? Known problems? Future work?
Self-Review
In this section, please self-review (answer all questions) on a suitable review checklist prior to requesting review from others. Select a review checklist based on what content is being merged in; see the Review Checklists section.
Reviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist