Skip to content

Fix JMAG Naming Issue #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmnewman3 merged 5 commits into from
Jun 21, 2024
Merged

Fix JMAG Naming Issue #345

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6cf4d38
add code to specify geometry to avoid naming issues
dmnewman3 May 22, 2024
342969d
Fix Stator ID in imag_2d
noguchi-takahiro May 28, 2024
bb254eb
Uncomment codes to rename parts
noguchi-takahiro May 28, 2024
15665b9
make changes based on feedback:
dmnewman3 May 29, 2024
4498941
fix SynR and flux linkage analyzer for JMAG23
dmnewman3 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mach_cad/tools/jmag/jmag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def open(
self.geometry_editor = self.jd.CreateGeometryEditor(
True
) # creates new geometry or edits the geometry.
self.geometry_editor.SetVersion(21.1)
self.doc = self.geometry_editor.GetDocument()
self.assembly = self.doc.GetAssembly()
return file_found
Expand Down
1 change: 1 addition & 0 deletions mach_eval/analyzers/electromagnetic/bspm/electrical_analysis/JMAG.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ def draw_jmag_model(
# open JMAG Geometry Editor
app.LaunchGeometryEditor()
geomApp = app.CreateGeometryEditor()
geomApp.SetVersion(21.1)
# geomApp.Show()
geomApp.NewDocument()
doc = geomApp.GetDocument()
Expand Down
7 changes: 7 additions & 0 deletions mach_eval/analyzers/electromagnetic/bspm/jmag_2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ def group(name, id_list):
partIDRange_Magnet = part_ID_list[2 : int(2 + self.machine_variant.p * 2)]
# id_sleeve = part_ID_list[int(2 + self.machine_variant.p * 2)]
id_statorCore = part_ID_list[int(2 + self.machine_variant.p * 2) + 1]
id_statorCore = part_ID_list[int(2 + self.machine_variant.p * 2)]
partIDRange_Coil = part_ID_list[
int(1 + self.machine_variant.p * 2)
+ 2 : int(2 + self.machine_variant.p * 2)
Expand All @@ -318,6 +319,12 @@ def group(name, id_list):
group("Magnet", partIDRange_Magnet)
group("Coils", partIDRange_Coil)

# """ Set Parts names """

app.GetModel(0).SetPartName(id_backiron, u"NotchedRotor")
app.GetModel(0).SetPartName(id_shaft, u"Shaft")
app.GetModel(0).SetPartName(id_statorCore, u"StatorCore")

""" Add Part to Set for later references """

def add_part_to_set(name, x, y, ID=None):
Expand Down