refactor: migrate faker to @faker-js/faker#1
Open
xDivisionByZerox wants to merge 4 commits intoShadey212:mainfrom
Open
refactor: migrate faker to @faker-js/faker#1xDivisionByZerox wants to merge 4 commits intoShadey212:mainfrom
xDivisionByZerox wants to merge 4 commits intoShadey212:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the old
fakerlibrary with the new community-driven@faker-js/fakerlibrary. The originalfakerlibrary, once a popular choice for generating fake data, became unmaintained in January 2022. In response, the community came together to create@faker-js/faker, ensuring continued support and improvements. You can read more about this on our website.For transparency, I want to mention that I'm one of the maintainers of the new library.
We are actively seeking projects that still use the old library. By migrating these projects, we aim to prevent developers from inadvertently using outdated libraries when searching for code examples.
Additional Information
It seems that you are not ignoring the
node_modulesdirectory from the git version control. This leads to a massive git diff/a lot of changed files in GitHub. You might want to think to add the directory to a.gitignorefile.