Skip to content

Fix funding stream address rotation panic at ~35,000 blocks #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyphae-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix funding stream address rotation panic at ~35,000 blocks #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions zebra-crosslink/zebra-consensus/src/block/subsidy/funding_streams.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ fn funding_stream_address_index(
))
.expect("no overflow should happen in this sub") as usize;

assert!(index > 0 && index <= num_addresses);
// spec formula will output an index starting at 1 but
// Zebra indices for addresses start at zero, return converted.
Some(index - 1)
assert!(index > 0);
// Wrap the index to prevent out-of-bounds panic when the address
// period spans more intervals than there are addresses (Crosslink fix).
Some((index - 1) % num_addresses)
}

/// Return the address corresponding to given height, network and funding stream receiver.
Expand Down