bump wasmtime to v27 #405
Merged
bump wasmtime to v27 #405
+718
−970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsteves
requested review from
a team,
lopert and
saga-dasgupta
and removed request for
a team
jacobsteves
force-pushed
the
js.bump-wasmtime-27-2
branch
from
7e9786a to
3cb3bed
Compare
| @@ -124,7 +124,7 @@ mod tests { | |||
| .arg(input_file.as_os_str()); | |||
| cmd.assert() | |||
| .failure() | |||
| .stderr("Error: Couldn\'t load the Function \"test/file/doesnt/exist\": failed to read input file: test/file/doesnt/exist\n"); | |||
| .stderr("Error: Couldn\'t load the Function \"test/file/doesnt/exist\": failed to read from `test/file/doesnt/exist`\n"); | |||
There was a problem hiding this comment.
Why did this change?
There was a problem hiding this comment.
The failed to read message comes directly from wasmtime and the message changed upstream
saga-dasgupta
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes wasmprof bump Shopify/wasmprof#55