Update CartLineFragment to query on BaseCartLine interface #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
While upgrading to
shopify-buy@3my team noticed that the SDK didn't support ComponentizableCartLine cart line items.We created a patched version that modifies
CartLineFragmentto query on the BaseCartLine interface to support bothCartLineandComponentizableCartLine.ComponentizableCartLinedoes have alineComponentsproperty that's not a part of theBaseCartLineinterface, but it is not required for our needs. This change aligns with the behaviour of v2.I thought I'd create a PR just in case this change was desired. We're good on our end, although we would prefer to use the official SDK if possible.