Update checkout.webUrl to use the same domain as JS Buy SDK v2 #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpprieto
approved these changes
Jun 17, 2025
| assert.strictEqual(result.webUrl, cart.checkoutUrl); | ||
| }); | ||
|
|
||
| test('it updates the value of _fd to 0 if it is present but with a different value', () => { |
Contributor
There was a problem hiding this comment.
Looks great, I'd add two more tests for completeness:
- the url has already other params in it (without
_fd) - the url has already other params including
_fd
Contributor
Author
There was a problem hiding this comment.
Added! Lines 514-530 in this file
kdaviduik
force-pushed
the
kd-prevent-redirect
branch
2 times, most recently
from
1fa0276 to
881ddcd
Compare
Without this change, if the shop's Online Store primary domain isn't configured correctly and pointing to Shopify, some buyers can be blocked from checkout.
kdaviduik
force-pushed
the
kd-prevent-redirect
branch
from
881ddcd to
4a06672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, if the shop's Online Store primary domain isn't configured correctly and pointing to Shopify, some buyers are unable to checkout successfully.