-
Notifications
You must be signed in to change notification settings - Fork 147
feat: add borderCurve and pointerEvents style properties #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
it needs this first facebook/react-native@a0800ff (types are now in react-native repo) |
| const {root} = render( | ||
| <ThemeProvider theme={theme}> | ||
| <Component opacity={0.5} pointerEvents="auto" /> | ||
| <Component opacity={0.5} removeClippedSubviews /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was pointerEvents replaced by removeClippedSubviews?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because pointerEvents is now present in style since rn 0.71 so this test failed. I have used removeClippedSubview but I could choose another property (that is not a style one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Native's borderCurve and pointerEvents don't seem to have been added to React Native's ViewStyle type. When clicking through ViewStyle on this line, borderCurve and pointerEvents are not included (see image below). This is causing the build failures. Do you know why they're not being included?
|
Yes, I added them in @types/react-native but now types are directly in react-native, a similar PR has been merged but related commits are not in react native 0.71.2. We have to wait a future version |
334b3da to
f86990a
Compare

Description
see comment #188 (comment)
Checklist