Add definition on mailbox callbacks #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domingo2000
force-pushed
the
add-definition-on-mailbox-callbacks
branch
from
cc32523 to
b5f4cc8
Compare
vinistock
approved these changes
Jul 15, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This looks great.
For some weird reason, CI seems to be stuck. Can you please rebase the PR?
domingo2000
force-pushed
the
add-definition-on-mailbox-callbacks
branch
from
b5f4cc8 to
3a04173
Compare
Contributor
Author
|
Just rebased, windows build still failing 😞. |
Member
|
Yes, we're getting hit by sparklemotion/sqlite3-ruby#628. I'm not exactly sure what is the solution yet. |
Member
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #377
Add Go To Definition for Action::Mailbox callbacks.
Screencast.from.01-06-25.12.28.39.webm