Merge pull request #1215 from Shopify/ps/fix-store-hosts-starting-wit…

…h-http

Fix validations for store hosts starting with http

.changeset/curly-boxes-switch.md

@@ -0,0 +1,5 @@
+---
+"@shopify/graphql-client": patch
+---
+
+Fix GraphQL client validations for store hosts starting with http

packages/graphql-client/src/api-client-utilities/tests/validation.test.ts

@@ -73,6 +73,26 @@ describe("validateDomainAndGetStoreUrl())", () => {
     });
     expect(domain).toEqual(`https://${domainOnly}`);
   });
+
+  it("returns a store url when a protocol-less store domain starting with http is provided", () => {
+    const domainOnly = "http-test-store.myshopify.io";
+
+    const domain = validateDomainAndGetStoreUrl({
+      client,
+      storeDomain: domainOnly,
+    });
+    expect(domain).toEqual(`https://${domainOnly}`);
+  });
+
+  it("returns a store url when a protocol-less store domain starting with https is provided", () => {
+    const domainOnly = "https-test-store.myshopify.io";
+
+    const domain = validateDomainAndGetStoreUrl({
+      client,
+      storeDomain: domainOnly,
+    });
+    expect(domain).toEqual(`https://${domainOnly}`);
+  });
 });
 
 describe("validateRequiredApiVersion()", () => {

packages/graphql-client/src/api-client-utilities/validations.ts

@@ -14,9 +14,10 @@ export function validateDomainAndGetStoreUrl({
 
     const trimmedDomain = storeDomain.trim();
 
-    const protocolUrl = trimmedDomain.startsWith("http")
-      ? trimmedDomain
-      : `https://${trimmedDomain}`;
+    const protocolUrl =
+      trimmedDomain.startsWith("http:") || trimmedDomain.startsWith("https:")
+        ? trimmedDomain
+        : `https://${trimmedDomain}`;
 
     const url = new URL(protocolUrl);
     url.protocol = "https";