Merge pull request #1202 from Shopify/fix_gift_card_types

Fix currency and balance types in GiftCards
Shopify · Feb 7, 2024 · f47257b · f47257b
2 parents f298bec + 224fbf5
commit f47257b
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 54 deletions.
diff --git a/.changeset/curly-grapes-rhyme.md b/.changeset/curly-grapes-rhyme.md
@@ -0,0 +1,5 @@
+---
+"@shopify/shopify-api": patch
+---
+
+Fixed the types of the `balance` and `currency` fields in the `GiftCard` object.
diff --git a/packages/shopify-api/rest/admin/2022-10/gift_card.ts b/packages/shopify-api/rest/admin/2022-10/gift_card.ts
@@ -7,9 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
 import {Session} from '../../../lib/session/session';
 import {ApiVersion} from '../../../lib/types';
 
-import {Balance} from './balance';
-import {Currency} from './currency';
-
 interface FindArgs {
   session: Session;
   id: number | string;
@@ -47,10 +44,7 @@ interface DisableArgs {
 export class GiftCard extends Base {
   public static apiVersion = ApiVersion.October22;
 
-  protected static hasOne: {[key: string]: typeof Base} = {
-    "balance": Balance,
-    "currency": Currency
-  };
+  protected static hasOne: {[key: string]: typeof Base} = {};
   protected static hasMany: {[key: string]: typeof Base} = {};
   protected static paths: ResourcePath[] = [
     {"http_method": "get", "operation": "count", "ids": [], "path": "gift_cards/count.json"},
@@ -168,10 +162,10 @@ export class GiftCard extends Base {
   }
 
   public api_client_id: number | null;
-  public balance: Balance | null | {[key: string]: any};
+  public balance: string | null;
   public code: string | null;
   public created_at: string | null;
-  public currency: Currency | null | {[key: string]: any};
+  public currency: string | null;
   public customer_id: number | null;
   public disabled_at: string | null;
   public expires_on: string | null;

diff --git a/packages/shopify-api/rest/admin/2023-01/gift_card.ts b/packages/shopify-api/rest/admin/2023-01/gift_card.ts
@@ -7,9 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
 import {Session} from '../../../lib/session/session';
 import {ApiVersion} from '../../../lib/types';
 
-import {Balance} from './balance';
-import {Currency} from './currency';
-
 interface FindArgs {
   session: Session;
   id: number | string;
@@ -47,10 +44,7 @@ interface DisableArgs {
 export class GiftCard extends Base {
   public static apiVersion = ApiVersion.January23;
 
-  protected static hasOne: {[key: string]: typeof Base} = {
-    "balance": Balance,
-    "currency": Currency
-  };
+  protected static hasOne: {[key: string]: typeof Base} = {};
   protected static hasMany: {[key: string]: typeof Base} = {};
   protected static paths: ResourcePath[] = [
     {"http_method": "get", "operation": "count", "ids": [], "path": "gift_cards/count.json"},
@@ -168,10 +162,10 @@ export class GiftCard extends Base {
   }
 
   public api_client_id: number | null;
-  public balance: Balance | null | {[key: string]: any};
+  public balance: string | null;
   public code: string | null;
   public created_at: string | null;
-  public currency: Currency | null | {[key: string]: any};
+  public currency: string | null;
   public customer_id: number | null;
   public disabled_at: string | null;
   public expires_on: string | null;

diff --git a/packages/shopify-api/rest/admin/2023-04/gift_card.ts b/packages/shopify-api/rest/admin/2023-04/gift_card.ts
@@ -7,9 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
 import {Session} from '../../../lib/session/session';
 import {ApiVersion} from '../../../lib/types';
 
-import {Balance} from './balance';
-import {Currency} from './currency';
-
 interface FindArgs {
   session: Session;
   id: number | string;
@@ -47,10 +44,7 @@ interface DisableArgs {
 export class GiftCard extends Base {
   public static apiVersion = ApiVersion.April23;
 
-  protected static hasOne: {[key: string]: typeof Base} = {
-    "balance": Balance,
-    "currency": Currency
-  };
+  protected static hasOne: {[key: string]: typeof Base} = {};
   protected static hasMany: {[key: string]: typeof Base} = {};
   protected static paths: ResourcePath[] = [
     {"http_method": "get", "operation": "count", "ids": [], "path": "gift_cards/count.json"},
@@ -168,10 +162,10 @@ export class GiftCard extends Base {
   }
 
   public api_client_id: number | null;
-  public balance: Balance | null | {[key: string]: any};
+  public balance: string | null;
   public code: string | null;
   public created_at: string | null;
-  public currency: Currency | null | {[key: string]: any};
+  public currency: string | null;
   public customer_id: number | null;
   public disabled_at: string | null;
   public expires_on: string | null;

diff --git a/packages/shopify-api/rest/admin/2023-07/gift_card.ts b/packages/shopify-api/rest/admin/2023-07/gift_card.ts
@@ -7,9 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
 import {Session} from '../../../lib/session/session';
 import {ApiVersion} from '../../../lib/types';
 
-import {Balance} from './balance';
-import {Currency} from './currency';
-
 interface FindArgs {
   session: Session;
   id: number | string;
@@ -47,10 +44,7 @@ interface DisableArgs {
 export class GiftCard extends Base {
   public static apiVersion = ApiVersion.July23;
 
-  protected static hasOne: {[key: string]: typeof Base} = {
-    "balance": Balance,
-    "currency": Currency
-  };
+  protected static hasOne: {[key: string]: typeof Base} = {};
   protected static hasMany: {[key: string]: typeof Base} = {};
   protected static paths: ResourcePath[] = [
     {"http_method": "get", "operation": "count", "ids": [], "path": "gift_cards/count.json"},
@@ -168,10 +162,10 @@ export class GiftCard extends Base {
   }
 
   public api_client_id: number | null;
-  public balance: Balance | null | {[key: string]: any};
+  public balance: string | null;
   public code: string | null;
   public created_at: string | null;
-  public currency: Currency | null | {[key: string]: any};
+  public currency: string | null;
   public customer_id: number | null;
   public disabled_at: string | null;
   public expires_on: string | null;

diff --git a/packages/shopify-api/rest/admin/2023-10/gift_card.ts b/packages/shopify-api/rest/admin/2023-10/gift_card.ts
@@ -7,9 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
 import {Session} from '../../../lib/session/session';
 import {ApiVersion} from '../../../lib/types';
 
-import {Balance} from './balance';
-import {Currency} from './currency';
-
 interface FindArgs {
   session: Session;
   id: number | string;
@@ -47,10 +44,7 @@ interface DisableArgs {
 export class GiftCard extends Base {
   public static apiVersion = ApiVersion.October23;
 
-  protected static hasOne: {[key: string]: typeof Base} = {
-    "balance": Balance,
-    "currency": Currency
-  };
+  protected static hasOne: {[key: string]: typeof Base} = {};
   protected static hasMany: {[key: string]: typeof Base} = {};
   protected static paths: ResourcePath[] = [
     {"http_method": "get", "operation": "count", "ids": [], "path": "gift_cards/count.json"},
@@ -168,10 +162,10 @@ export class GiftCard extends Base {
   }
 
   public api_client_id: number | null;
-  public balance: Balance | null | {[key: string]: any};
+  public balance: string | null;
   public code: string | null;
   public created_at: string | null;
-  public currency: Currency | null | {[key: string]: any};
+  public currency: string | null;
   public customer_id: number | null;
   public disabled_at: string | null;
   public expires_on: string | null;

diff --git a/packages/shopify-api/rest/admin/2024-01/gift_card.ts b/packages/shopify-api/rest/admin/2024-01/gift_card.ts
@@ -7,9 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
 import {Session} from '../../../lib/session/session';
 import {ApiVersion} from '../../../lib/types';
 
-import {Balance} from './balance';
-import {Currency} from './currency';
-
 interface FindArgs {
   session: Session;
   id: number | string;
@@ -47,10 +44,7 @@ interface DisableArgs {
 export class GiftCard extends Base {
   public static apiVersion = ApiVersion.January24;
 
-  protected static hasOne: {[key: string]: typeof Base} = {
-    "balance": Balance,
-    "currency": Currency
-  };
+  protected static hasOne: {[key: string]: typeof Base} = {};
   protected static hasMany: {[key: string]: typeof Base} = {};
   protected static paths: ResourcePath[] = [
     {"http_method": "get", "operation": "count", "ids": [], "path": "gift_cards/count.json"},
@@ -168,10 +162,10 @@ export class GiftCard extends Base {
   }
 
   public api_client_id: number | null;
-  public balance: Balance | null | {[key: string]: any};
+  public balance: string | null;
   public code: string | null;
   public created_at: string | null;
-  public currency: Currency | null | {[key: string]: any};
+  public currency: string | null;
   public customer_id: number | null;
   public disabled_at: string | null;
   public expires_on: string | null;