This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Adding @shopify/api-codegen-preset package
#1044
Merged
+2,493
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
requested review from
melissaluu,
scottdixon and
a team
and removed request for
a team
paulomarg
force-pushed
the
add_codegen_preset_package
branch
from
de48142 to
4072aef
Compare
melissaluu
reviewed
Nov 8, 2023
paulomarg
changed the title
@shopify/codegen-preset package@shopify/api-codegen-preset package
melissaluu
approved these changes
Nov 8, 2023
paulomarg
force-pushed
the
add_codegen_preset_package
branch
2 times, most recently
from
f2f9934 to
febddbf
Compare
scottdixon
force-pushed
the
sd-admin-client
branch
from
41bf15b to
c1624ee
Compare
paulomarg
force-pushed
the
add_codegen_preset_package
branch
from
febddbf to
4b1f031
Compare
scottdixon
force-pushed
the
sd-admin-client
branch
from
15ef5ca to
bb00656
Compare
paulomarg
force-pushed
the
add_codegen_preset_package
branch
from
4b1f031 to
8b805ec
Compare
paulomarg
force-pushed
the
add_codegen_preset_package
branch
from
8b805ec to
e5796da
Compare
lizkenyon
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want to be able to generate TS types from GraphQL queries. The approach we've decided to use is to run GraphQL codegen to parse the queries and produce those types, then integrate the types with our clients.
WHAT is this pull request doing?
Since it takes a little bit of configuration to get codegen to do exactly what we want, we're introducing a package to wrap around that configuration and provide abstractions at different layers to enable apps to have full control over how to parse their files.
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)