Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

[GraphQL Client] Rename customHeaders to headers #1049

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

melissaluu
Copy link
Contributor

@melissaluu melissaluu commented Nov 9, 2023

WHY are these changes introduced?

Renamed customHeaders to headers in the API client utils and types for easier readability.

Also had to update the storefront-api-client tests because it was breaking CI tests due to the utility and type name changes

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@melissaluu melissaluu requested a review from a team as a code owner November 9, 2023 17:14
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@melissaluu melissaluu merged commit 28f7107 into main Nov 9, 2023
@melissaluu melissaluu deleted the ml-graphql-client-rename-customHeader branch November 9, 2023 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants