Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

[Turbo] Add build dependency to local test step to mimic CI behaviour #1051

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

melissaluu
Copy link
Contributor

WHY are these changes introduced?

Add a build dependency in the local turbo > test pipeline so devs can recreate the our CI steps environment.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@melissaluu melissaluu requested a review from a team as a code owner November 9, 2023 21:05
@melissaluu melissaluu requested a review from paulomarg November 9, 2023 21:05
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call! Does this mean we no longer need to do that in the workflow file now?

@melissaluu
Copy link
Contributor Author

Does this mean we no longer need to do that in the workflow file now?

@paulomarg - no..this is for the local turbo test but we can add this to the test:ci pipeline and update the github workflow and remove that build step - let me try that!

@melissaluu melissaluu force-pushed the ml-turbo-add-test-build branch from c4e199c to c47ae1d Compare November 9, 2023 21:26
@melissaluu
Copy link
Contributor Author

Does this mean we no longer need to do that in the workflow file now?

@paulomarg - no..this is for the local turbo test but we can add this to the test:ci pipeline and update the github workflow and remove that build step - let me try that!

Ahh boo - the CI workflow still needs to include the build step but I did add the dependency to the test:ci as well.

@melissaluu melissaluu merged commit 01257b0 into main Nov 9, 2023
@melissaluu melissaluu deleted the ml-turbo-add-test-build branch November 9, 2023 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants