This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Add GQL types for Admin API #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissaluu
reviewed
Nov 10, 2023
paulomarg
force-pushed
the
add_graphql_types
branch
from
a8edb7f to
2874223
Compare
melissaluu
reviewed
Nov 13, 2023
melissaluu
reviewed
Nov 13, 2023
paulomarg
force-pushed
the
add_graphql_types
branch
from
9a55040 to
ed7bb21
Compare
paulomarg
force-pushed
the
add_graphql_types
branch
from
ed7bb21 to
ef053fa
Compare
4 tasks
paulomarg
force-pushed
the
add_graphql_types
branch
from
39843aa to
761bb77
Compare
lizkenyon
approved these changes
Nov 15, 2023
melissaluu
reviewed
Nov 15, 2023
melissaluu
approved these changes
Nov 15, 2023
paulomarg
force-pushed
the
add_graphql_types
branch
from
761bb77 to
d8d6f24
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want to type GraphQL queries automatically, so apps can easily get the return types of their queries / mutations in their TS code.
WHAT is this pull request doing?
Updating the types in
@shopify/admin-api-clientso that the file created by@shopify/api-codegen-presetautomatically causes queries to be typed, without user intervention.This way, the client will be able to type the response:
and the variables a query expects:
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)