This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Use new GraphQL clients in shopify-api #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
changed the title
paulomarg
force-pushed
the
use_new_clients
branch
from
6a78c48 to
f71b46b
Compare
paulomarg
force-pushed
the
refactor_adapter_fetch
branch
from
185633e to
f2135c8
Compare
paulomarg
force-pushed
the
use_new_clients
branch
2 times, most recently
from
78c39d0 to
eb5d000
Compare
paulomarg
changed the title
paulomarg
changed the title
paulomarg
changed the title
paulomarg
force-pushed
the
refactor_adapter_fetch
branch
from
f2135c8 to
0311d59
Compare
paulomarg
force-pushed
the
use_new_clients
branch
3 times, most recently
from
c474907 to
77f10ca
Compare
lizkenyon
reviewed
Dec 4, 2023
paulomarg
force-pushed
the
refactor_adapter_fetch
branch
from
0311d59 to
64f6141
Compare
paulomarg
force-pushed
the
use_new_clients
branch
4 times, most recently
from
8b0fcbc to
5ab5f3d
Compare
4 tasks
paulomarg
commented
Dec 7, 2023
lizkenyon
reviewed
Dec 7, 2023
byrichardpowell
approved these changes
Dec 7, 2023
| "@shopify/graphql-client": patch | ||
| --- | ||
|
|
||
| Use the new GraphQL API clients in shopify-api to use all of the latest features, including automatic types for query / mutation return object and variables. |
There was a problem hiding this comment.
Same question here as in another PR:
- Can we show what this means? Perhaps a GIF?
- Can we link to a PR that shows the changes needed to make use of the new awesomeness?
There was a problem hiding this comment.
I think the best thing here would be to add a documentation page that goes over that step by step. That page can include a video / gif of the experience, plus instructions on setting it up. Maybe we can make that a follow up and ensure we link there from the changelog / migration guide?
packages/shopify-api/lib/__test-helpers__/to-match-made-http-request.ts
Outdated
Show resolved
Hide resolved
paulomarg
force-pushed
the
use_new_clients
branch
from
e2547f9 to
5ab5f3d
Compare
paulomarg
force-pushed
the
use_new_clients
branch
2 times, most recently
from
dc6d659 to
1328b11
Compare
paulomarg
force-pushed
the
use_new_clients
branch
from
1328b11 to
1b40d36
Compare
paulomarg
force-pushed
the
use_new_clients
branch
from
3ff82f2 to
e90a7c3
Compare
byrichardpowell
approved these changes
Dec 11, 2023
matteodepalo
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Now that
@shopify/storefront-api-clientand@shopify/admin-api-clientare released, we want to start using them in this package.WHAT is this pull request doing?
Underpinning the existing clients with the new ones. As part of this change, I also did a bit of refactoring on the tests and rearranged the files inside
lib/clientsto match the exported object more closely.Since this is already a big change (mostly due to tests moving around), I'm setting up an update of the REST client in a different PR.
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)