This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Revamp REST client to match new clients #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
use_new_clients
branch
from
6a78c48 to
f71b46b
Compare
paulomarg
force-pushed
the
revamp_rest_client
branch
from
7558b3e to
46d29aa
Compare
paulomarg
force-pushed
the
use_new_clients
branch
from
f71b46b to
eb5d000
Compare
paulomarg
force-pushed
the
revamp_rest_client
branch
2 times, most recently
from
f24a1f7 to
ea9bb3e
Compare
paulomarg
force-pushed
the
use_new_clients
branch
from
78c39d0 to
eb5d000
Compare
paulomarg
force-pushed
the
revamp_rest_client
branch
from
ea9bb3e to
55fbbbd
Compare
paulomarg
force-pushed
the
revamp_rest_client
branch
from
55fbbbd to
d3fe03a
Compare
paulomarg
changed the title
paulomarg
force-pushed
the
revamp_rest_client
branch
from
d3fe03a to
f275293
Compare
paulomarg
force-pushed
the
use_new_clients
branch
3 times, most recently
from
c474907 to
77f10ca
Compare
|
This PR no longer applies, we've decided to go a different way and not refactor the REST client since the GraphQL ones won't change quite as much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The new GraphQL clients work slightly differently than the previous ones in
shopify-api, in that the parameters they accept are slightly different.Once we start using them, the REST client would be inconsistent and might lead to confusion.
WHAT is this pull request doing?
Revamping the REST client to:
client.get(path, { /* options */ })so that it is more similar to the new clientsType of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)