Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Fix recurring app charge currency type #1331

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Fix recurring app charge currency type #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-hotels-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@shopify/shopify-api": patch
---

Fixed an issue with the `RecurringApplicationCharge` REST resource currency type
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2022-10/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.October22;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2023-01/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.January23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2023-04/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.April23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2023-07/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.July23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2023-10/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.October23;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2024-01/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.January24;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
8 changes: 2 additions & 6 deletions packages/shopify-api/rest/admin/2024-04/recurring_application_charge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
import {Session} from '../../../lib/session/session';
import {ApiVersion} from '../../../lib/types';

import {Currency} from './currency';

interface FindArgs {
session: Session;
id: number | string;
Expand All @@ -32,9 +30,7 @@ interface CustomizeArgs {
export class RecurringApplicationCharge extends Base {
public static apiVersion = ApiVersion.April24;

protected static hasOne: {[key: string]: typeof Base} = {
"currency": Currency
};
protected static hasOne: {[key: string]: typeof Base} = {};
protected static hasMany: {[key: string]: typeof Base} = {};
protected static paths: ResourcePath[] = [
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
Expand Down Expand Up @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
public capped_amount: string | number | null;
public confirmation_url: string | null;
public created_at: string | null;
public currency: Currency | null | {[key: string]: any};
public currency: string | null;
public id: number | null;
public name: string | null;
public price: string | number | null;
Expand Down
Loading