Skip to content

[patch] Fix TypeError in webhook job templates with shopify_api >= 16.0.0 #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizkenyon merged 1 commit into from
Jan 8, 2026
Merged

[patch] Fix TypeError in webhook job templates with shopify_api >= 16.0.0 #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Unreleased
----------
- [Patch] Fix sorbet errors in generated webhook handlers

23.0.1 (December 22, 2025)
- Fix engine initialization [#2040](https://github.com/Shopify/shopify_app/pull/2040)
Expand Down
8 changes: 3 additions & 5 deletions lib/generators/shopify_app/add_app_uninstalled_job/templates/app_uninstalled_job.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
class AppUninstalledJob < ActiveJob::Base
include ShopifyAPI::Webhooks::WebhookHandler
extend ShopifyAPI::Webhooks::WebhookHandler

class << self
def handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end
def self.handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end

def perform(topic:, shop_domain:, webhook:)
Expand Down
8 changes: 3 additions & 5 deletions lib/generators/shopify_app/add_privacy_jobs/templates/customers_data_request_job.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
class CustomersDataRequestJob < ActiveJob::Base
include ShopifyAPI::Webhooks::WebhookHandler
extend ShopifyAPI::Webhooks::WebhookHandler

class << self
def handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end
def self.handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end

def perform(topic:, shop_domain:, webhook:)
Expand Down
8 changes: 3 additions & 5 deletions lib/generators/shopify_app/add_privacy_jobs/templates/customers_redact_job.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
class CustomersRedactJob < ActiveJob::Base
include ShopifyAPI::Webhooks::WebhookHandler
extend ShopifyAPI::Webhooks::WebhookHandler

class << self
def handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end
def self.handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end

def perform(topic:, shop_domain:, webhook:)
Expand Down
8 changes: 3 additions & 5 deletions lib/generators/shopify_app/add_privacy_jobs/templates/shop_redact_job.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
class ShopRedactJob < ActiveJob::Base
include ShopifyAPI::Webhooks::WebhookHandler
extend ShopifyAPI::Webhooks::WebhookHandler

class << self
def handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end
def self.handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end

def perform(topic:, shop_domain:, webhook:)
Expand Down
8 changes: 3 additions & 5 deletions lib/generators/shopify_app/add_webhook/templates/webhook_job.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
class <%= @job_class_name %> < ActiveJob::Base
include ShopifyAPI::Webhooks::WebhookHandler
extend ShopifyAPI::Webhooks::WebhookHandler

class << self
def handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end
def self.handle(topic:, shop:, body:, webhook_id:, api_version:)
perform_later(topic: topic, shop_domain: shop, webhook: body)
end

def perform(topic:, shop_domain:, webhook:)
Expand Down