Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in comments #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -235,7 +235,7 @@ Toxiproxy for Windows is available for download at https://github.com/Shopify/to
**Docker**

Toxiproxy is available on [Github container registry](https://github.com/Shopify/toxiproxy/pkgs/container/toxiproxy).
Old versions `<= 2.1.4` are available on on [Docker Hub](https://hub.docker.com/r/shopify/toxiproxy/).
Old versions `<= 2.1.4` are available on [Docker Hub](https://hub.docker.com/r/shopify/toxiproxy/).

```bash
$ docker pull ghcr.io/shopify/toxiproxy
2 changes: 1 addition & 1 deletion link.go
Original file line number Diff line number Diff line change
@@ -232,7 +232,7 @@ func (link *ToxicLink) RemoveToxic(ctx context.Context, toxic *toxics.ToxicWrapp
}(link.stubs[toxic_index-1], stop)

// Unblock the previous toxic if it is trying to flush
// If the previous toxic is closed, continue flusing until we reach the end.
// If the previous toxic is closed, continue flushing until we reach the end.
interrupted := false
stopped := false
for !interrupted {
2 changes: 1 addition & 1 deletion stream/io_chan_test.go
Original file line number Diff line number Diff line change
@@ -202,7 +202,7 @@ func TestStream_ReadInterrupt(t *testing.T) {
}

if n != 0 {
t.Fatalf("Read still returned data after interrput: %d bytes", n)
t.Fatalf("Read still returned data after interrupt: %d bytes", n)
}

// Try writing again after the channel was interrupted
4 changes: 2 additions & 2 deletions toxics/timeout_test.go
Original file line number Diff line number Diff line change
@@ -106,11 +106,11 @@ func TestTimeoutToxicClosesConnectionOnRemove(t *testing.T) {
buf := make([]byte, 1)
_, err := conn.Read(buf)
if err != io.EOF {
t.Fatal("expected EOF from closed connetion")
t.Fatal("expected EOF from closed connection")
}
_, err = serverConn.Read(buf)
if err != io.EOF {
t.Fatal("expected EOF from closed server connetion")
t.Fatal("expected EOF from closed server connection")
}
})
if err != nil {
2 changes: 1 addition & 1 deletion toxics/toxic.go
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ import (
"github.com/Shopify/toxiproxy/v2/stream"
)

// A Toxic is something that can be attatched to a link to modify the way
// A Toxic is something that can be attached to a link to modify the way
// data can be passed through (for example, by adding latency)
//
// Toxic