Add missing peer dependencies in eslint-plugin and stylelint-plugin #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@shopify/eslint-plugin
and@shopify/stylelint-plugin
are missing peerDependencies on@babel/core
andprettier
.While it's not a massive problem, it does make life harder for package managers when trying to optimize package installation, see Implicit Transitive Peer Dependencies.
yarn currently reports both of these packages as missing peer dependencies:
Noted both changes as
patch
, because consumers will already have been required to fulfil these requirements, so it's not forcing them to upgrade or install new packages with potential breaking changes.