Allow for passing middleware to quic.Dial and quic.Serve #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/quic-middleware
branch
3 times, most recently
from
f77a836 to
7639dbe
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ChrisSchinnerl
force-pushed
the
chris/quic-middleware
branch
from
7639dbe to
f20725e
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds middleware functionality to QUIC connections, enabling wrapping of net.Conn streams for monitoring or rate limiting purposes. It also includes an unrelated bug fix for a potential double-close scenario in the parallel syncer.
- Added
WithStreamMiddlewareoption for QUIC client to wrap dialed streams - Added
WithServeStreamMiddlewareoption for QUIC server to wrap accepted streams - Refactored
quic.Servesignature to use variadic options instead of direct logger parameter (breaking change)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rhp/v4/quic/quic.go | Core implementation of stream middleware for both client and server QUIC transports, including options pattern for Serve function |
| rhp/v4/quic/quic_test.go | Updated test to use new transport struct fields |
| rhp/v4/rpc_test.go | Added comprehensive test for middleware functionality and updated existing test to use new logger option |
| testutil/host.go | Updated ServeQUIC signature to accept variadic ServeOption instead of logger parameter |
| syncer/parallel_sync.go | Fixed potential double-close of finishCh channel using sync.Once |
| .changeset/fix_double_close_of_finishch_in_parallelsync.md | Changeset for syncer bug fix |
| .changeset/add_option_to_add_middleware_to_dialed_or_accepted_quic_streams.md | Changeset for QUIC middleware feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which then allows for wrapping a
net.Connin whatever middleware we deem necessary for monitoring or rate limiting it.This is not quite as accurate as the wrapping we perform on TCP connections, but
quic-gois so optimized that it uses RawConn for reads. Which we can't monitor or limit.Fixes #377