[MSUE-231] - Removes batch retry when network request blocked by firewall #160
+98
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Issue
When network limits access to Sift API service, Sift framework generates excessive amount of network traffic.
Such traffic is generated as result retry policy that does not detect blocked requests. This leads to the situation when we have a mix of requests which contains retry requests and requests for newly generated requests
Example of such behaviour:

Solution
Based on observation there is a specific set of error that could indicate that network requests are blocked and drop retries when they are detected.
Summary
SFStubHttpProtocol
to simulate different network errors for requestsTesting
Block access to API endpoint.
SiftUploader should send only one request per batch when network is blocked
Checklist