Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed tables view not honouring order by in traces explorer #6769

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jan 8, 2025

Summary

Here the sorting via orderBy query was not being honoured due a manually sorting added in between, that was added due to some other issue - here - #5248

But we dont need that anymore as the logic has shifted to BE, hence reverted it, with this the orderBy query sorting is getting correctly rendered. (check video below)

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/2130

Screenshots

Screen.Recording.2025-01-15.at.10.38.14.AM.mov

Affected Areas and Manually Tested Areas


Important

Removes manual sorting in createTableColumnsFromQuery.ts to restore orderBy query sorting in traces explorer.

  • Behavior:
    • Removes manual sorting logic in createTableColumnsFromQuery.ts that was overriding orderBy query sorting.
    • Restores correct sorting behavior based on orderBy query in traces explorer.
  • Misc:
    • Reverts changes from a previous PR that added the manual sorting logic.

This description was created by Ellipsis for daf98c3. It will automatically update as commits are pushed.

Copy link

github-actions bot commented Jan 8, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jan 8, 2025
@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review January 15, 2025 05:17
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to daf98c3 in 12 seconds

More details
  • Looked at 34 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_jfTbKNCe27q6gll8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@SagarRajput-7
Copy link
Contributor Author

@nityanandagohain - please review the video above for expected behaviour, post that I will merge this, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants