fix: fixed tables view not honouring order by in traces explorer #6769
+0
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here the sorting via orderBy query was not being honoured due a manually sorting added in between, that was added due to some other issue - here - #5248
But we dont need that anymore as the logic has shifted to BE, hence reverted it, with this the orderBy query sorting is getting correctly rendered. (check video below)
Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/2130
Screenshots
Screen.Recording.2025-01-15.at.10.38.14.AM.mov
Affected Areas and Manually Tested Areas
Important
Removes manual sorting in
createTableColumnsFromQuery.ts
to restoreorderBy
query sorting in traces explorer.createTableColumnsFromQuery.ts
that was overridingorderBy
query sorting.orderBy
query in traces explorer.This description was created by for daf98c3. It will automatically update as commits are pushed.