Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid loading Segment analytics when SEGMENT_ID is not set #6776

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seuros
Copy link

@seuros seuros commented Jan 8, 2025

Added a check to prevent loading the Segment analytics script when SEGMENT_ID is not set.


Important

Adds a check in index.html.ejs to load Segment analytics only if SEGMENT_ID is set.

  • Behavior:
    • Adds a check in index.html.ejs to load Segment analytics script only if SEGMENT_ID is set.
    • Prevents loading and execution of Segment analytics when SEGMENT_ID is not configured.

This description was created by Ellipsis for ad97339. It will automatically update as commits are pushed.

@seuros seuros requested a review from YounixM as a code owner January 8, 2025 15:44
Copy link

welcome bot commented Jan 8, 2025

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ad97339 in 23 seconds

More details
  • Looked at 154 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/index.html.ejs:104
  • Draft comment:
    Consider using consistent indentation for better readability. The current script block has mixed spaces and tabs.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The indentation in the JavaScript code is inconsistent, which can affect readability and maintainability.
2. frontend/src/index.html.ejs:100
  • Draft comment:
    Avoid using inline styles in the script tags. Consider moving the script content to an external JavaScript file for better maintainability. This applies to both the Intercom and Segment scripts.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_ygo4D2gqU6gWJpCM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@seuros seuros marked this pull request as draft January 8, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants