Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement deployments in k8s infra monitoring #6786

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Jan 9, 2025

Summary

Implementation of deployments entity for Infra Monitoring

  • Deployments list table
  • Deployments details page

Related Issues / PR's

N/A

Screenshots

Screenshot 2025-01-09 at 1 31 06 PM Screenshot 2025-01-09 at 1 31 25 PM

Affected Areas and Manually Tested Areas

Infra Monitoring section


Important

Add Kubernetes deployment monitoring with list and detail views, including metrics, logs, traces, and events.

  • Behavior:
    • Add K8sDeploymentsList and DeploymentDetails components for listing and viewing deployment details.
    • Integrate deployment metrics, logs, traces, and events views in DeploymentDetails.tsx.
    • Add filtering and pagination for deployments in K8sDeploymentsList.tsx.
  • API:
    • Add getK8sDeploymentsList function in getK8sDeploymentsList.ts to fetch deployment data.
    • Add useGetK8sDeploymentsList hook for querying deployment data.
  • Styles:
    • Add styles for deployment components in DeploymentDetails.styles.scss and K8sDeploymentsList.styles.scss.
  • Constants:
    • Add QUERY_KEYS for deployment-related queries in constants.ts.

This description was created by Ellipsis for 935f11d. It will automatically update as commits are pushed.

@amlannandy amlannandy requested a review from YounixM as a code owner January 9, 2025 07:29
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added enhancement New feature or request docs required labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 8afcbc8 in 1 minute and 34 seconds

More details
  • Looked at 4746 lines of code in 31 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_WC8XBc3vcToAd1op


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 12b6670 in 26 seconds

More details
  • Looked at 39 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/hooks/infraMonitoring/useGetK8sDeploymentsList.ts:37
  • Draft comment:
    The query key has been correctly updated to GET_DEPLOYMENT_LIST to reflect the new functionality for deployments.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from GET_HOST_LIST to GET_DEPLOYMENT_LIST in useGetK8sDeploymentsList.ts is correct and aligns with the new functionality for deployments.
2. frontend/src/hooks/infraMonitoring/useGetK8sNodesList.ts:37
  • Draft comment:
    The query key has been correctly updated to GET_NODE_LIST to reflect the functionality for nodes.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from GET_HOST_LIST to GET_NODE_LIST in useGetK8sNodesList.ts is correct and aligns with the functionality for nodes.

Workflow ID: wflow_L2HWLzwt0ykQ60Dq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 469ea25 in 48 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx:234
  • Draft comment:
    Ensure that the new color Color.BG_SLATE_400 for the Tag component maintains sufficient contrast for accessibility. Consider using a tool to verify color contrast ratios.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The color change for the Tag component is appropriate, but it's important to ensure that the new color is accessible and maintains good contrast.

Workflow ID: wflow_2OK9ocmREA9VKhxP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Jan 9, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 935f11d in 1 minute and 23 seconds

More details
  • Looked at 121 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:108
  • Draft comment:
    The id for the key object is repeated as 'k8s_deployment_name--string--resource--false'. Consider using unique IDs for each key object to avoid potential conflicts.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/Events/DeploymentEvents.tsx:182
  • Draft comment:
    The handleExpandRow function is defined twice with the same logic. Consider refactoring to avoid code duplication. This issue is also present in DeploymentDetails.tsx.
  • Reason this comment was not posted:
    Comment was on unchanged code.
3. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/Logs/DeploymentLogs.tsx:49
  • Draft comment:
    The handleExpandRow function is defined twice with the same logic. Consider refactoring to avoid code duplication. This issue is also present in DeploymentEvents.tsx.
  • Reason this comment was not posted:
    Marked as duplicate.
4. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:223
  • Draft comment:
    Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to the style prop on line 421 and style prop on line 425.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
5. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:259
  • Draft comment:
    Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to the style prop on line 421 and style prop on line 425.
  • Reason this comment was not posted:
    Marked as duplicate.
6. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:276
  • Draft comment:
    Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to the style prop on line 421 and style prop on line 425.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_a7Ipt72LbbgFqhz1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs not required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant