-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement deployments in k8s infra monitoring #6786
base: main
Are you sure you want to change the base?
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 8afcbc8 in 1 minute and 34 seconds
More details
- Looked at
4746
lines of code in31
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_WC8XBc3vcToAd1op
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 12b6670 in 26 seconds
More details
- Looked at
39
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/hooks/infraMonitoring/useGetK8sDeploymentsList.ts:37
- Draft comment:
The query key has been correctly updated toGET_DEPLOYMENT_LIST
to reflect the new functionality for deployments. - Reason this comment was not posted:
Confidence changes required:0%
The change fromGET_HOST_LIST
toGET_DEPLOYMENT_LIST
inuseGetK8sDeploymentsList.ts
is correct and aligns with the new functionality for deployments.
2. frontend/src/hooks/infraMonitoring/useGetK8sNodesList.ts:37
- Draft comment:
The query key has been correctly updated toGET_NODE_LIST
to reflect the functionality for nodes. - Reason this comment was not posted:
Confidence changes required:0%
The change fromGET_HOST_LIST
toGET_NODE_LIST
inuseGetK8sNodesList.ts
is correct and aligns with the functionality for nodes.
Workflow ID: wflow_L2HWLzwt0ykQ60Dq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 469ea25 in 48 seconds
More details
- Looked at
18
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx:234
- Draft comment:
Ensure that the new colorColor.BG_SLATE_400
for the Tag component maintains sufficient contrast for accessibility. Consider using a tool to verify color contrast ratios. - Reason this comment was not posted:
Confidence changes required:50%
The color change for the Tag component is appropriate, but it's important to ensure that the new color is accessible and maintains good contrast.
Workflow ID: wflow_2OK9ocmREA9VKhxP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 935f11d in 1 minute and 23 seconds
More details
- Looked at
121
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
6
drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:108
- Draft comment:
Theid
for the key object is repeated as 'k8s_deployment_name--string--resource--false'. Consider using unique IDs for each key object to avoid potential conflicts. - Reason this comment was not posted:
Comment was on unchanged code.
2. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/Events/DeploymentEvents.tsx:182
- Draft comment:
ThehandleExpandRow
function is defined twice with the same logic. Consider refactoring to avoid code duplication. This issue is also present inDeploymentDetails.tsx
. - Reason this comment was not posted:
Comment was on unchanged code.
3. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/Logs/DeploymentLogs.tsx:49
- Draft comment:
ThehandleExpandRow
function is defined twice with the same logic. Consider refactoring to avoid code duplication. This issue is also present inDeploymentEvents.tsx
. - Reason this comment was not posted:
Marked as duplicate.
4. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:223
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to thestyle
prop on line 421 andstyle
prop on line 425. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
5. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:259
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to thestyle
prop on line 421 andstyle
prop on line 425. - Reason this comment was not posted:
Marked as duplicate.
6. frontend/src/container/InfraMonitoringK8s/Deployments/DeploymentDetails/DeploymentDetails.tsx:276
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to thestyle
prop on line 421 andstyle
prop on line 425. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_a7Ipt72LbbgFqhz1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Implementation of deployments entity for Infra Monitoring
Related Issues / PR's
N/A
Screenshots
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Add Kubernetes deployment monitoring with list and detail views, including metrics, logs, traces, and events.
K8sDeploymentsList
andDeploymentDetails
components for listing and viewing deployment details.DeploymentDetails.tsx
.K8sDeploymentsList.tsx
.getK8sDeploymentsList
function ingetK8sDeploymentsList.ts
to fetch deployment data.useGetK8sDeploymentsList
hook for querying deployment data.DeploymentDetails.styles.scss
andK8sDeploymentsList.styles.scss
.QUERY_KEYS
for deployment-related queries inconstants.ts
.This description was created by for 935f11d. It will automatically update as commits are pushed.