-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: infra monitoring bug fixes #6795
base: main
Are you sure you want to change the base?
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
48e80d1
to
9f5671a
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 9f5671a in 1 minute and 42 seconds
More details
- Looked at
705
lines of code in16
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/PodDetails.tsx:53
- Draft comment:
Verify that the change inTimeRangeOffset
from1000000
to1000000000
aligns with the intended time unit conversion. This affects how time is calculated and could impact functionality if not intended. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_3B9cfjzfFM6xbGWp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
9f5671a
to
021251c
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 021251c in 47 seconds
More details
- Looked at
24
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_XLyChPj4JjXnSO85
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Related Issues / PR's
Screenshots
Affected Areas and Manually Tested Areas
Important
Fixes and improvements in Infra Monitoring K8s module, including filter handling, UI adjustments, and event logging.
InfraMonitoringK8s.tsx
.NodeEvents.tsx
andEvents.tsx
.InfraMonitoringK8s.styles.scss
andK8sNodesList.tsx
.PodDetails.tsx
andNodeDetails.tsx
.InfraMonitoringK8s.styles.scss
.InfraMonitoringK8s.styles.scss
andK8sNodesList.tsx
.commonUtils.tsx
.QueryBuilderSearch/index.tsx
anduseAutoComplete.ts
.InfraMonitoringK8s.tsx
.InfraMonitoringK8s.tsx
andK8sNodesList.tsx
.This description was created by for 021251c. It will automatically update as commits are pushed.