Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: infra monitoring bug fixes #6795

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Jan 10, 2025

Summary

  • Fixed time range issues in pod metrics
  • fixed color issues in light mode
  • reset filters when switching between entities
  • show attribute logs as well on expanding an event
  • adjust table styling
  • adjust how filters are selected for table query
  • other minor fixes

Related Issues / PR's

Screenshots

Screenshot 2025-01-15 at 10 29 06 AM Screenshot 2025-01-15 at 10 29 17 AM Screenshot 2025-01-15 at 10 28 59 AM

Affected Areas and Manually Tested Areas


Important

Fixes and improvements in Infra Monitoring K8s module, including filter handling, UI adjustments, and event logging.

  • Behavior:
    • Reset filters when switching between entities in InfraMonitoringK8s.tsx.
    • Show attribute logs on event expansion in NodeEvents.tsx and Events.tsx.
    • Adjust table styling and column widths in InfraMonitoringK8s.styles.scss and K8sNodesList.tsx.
    • Handle time range issues in PodDetails.tsx and NodeDetails.tsx.
  • UI Adjustments:
    • Fix color issues in light mode in InfraMonitoringK8s.styles.scss.
    • Adjust table column widths in InfraMonitoringK8s.styles.scss and K8sNodesList.tsx.
    • Update progress bar colors in commonUtils.tsx.
  • Filter Handling:
    • Adjust filter selection logic in QueryBuilderSearch/index.tsx and useAutoComplete.ts.
    • Reset filters on category change in InfraMonitoringK8s.tsx.
  • Misc:
    • Remove unused code and comments in InfraMonitoringK8s.tsx and K8sNodesList.tsx.

This description was created by Ellipsis for 021251c. It will automatically update as commits are pushed.

@github-actions github-actions bot added bug Something isn't working chore labels Jan 10, 2025
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@amlannandy amlannandy force-pushed the feat/infra-monitoring-fixes branch from 48e80d1 to 9f5671a Compare January 13, 2025 08:43
@amlannandy amlannandy marked this pull request as ready for review January 13, 2025 08:43
@amlannandy amlannandy requested a review from YounixM as a code owner January 13, 2025 08:43
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9f5671a in 1 minute and 42 seconds

More details
  • Looked at 705 lines of code in 16 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/PodDetails.tsx:53
  • Draft comment:
    Verify that the change in TimeRangeOffset from 1000000 to 1000000000 aligns with the intended time unit conversion. This affects how time is calculated and could impact functionality if not intended.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_3B9cfjzfFM6xbGWp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@amlannandy amlannandy force-pushed the feat/infra-monitoring-fixes branch from 9f5671a to 021251c Compare January 13, 2025 08:50
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 021251c in 47 seconds

More details
  • Looked at 24 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_XLyChPj4JjXnSO85


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant